From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicolas.ferre@atmel.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
Alexander Morozov <linux@meltdown.ru>
Subject: Re: [PATCH 1/3] ASoC: codecs: wm8904: add dt ids table
Date: Mon, 15 Dec 2014 11:28:20 +0800 [thread overview]
Message-ID: <548E5554.6050900@atmel.com> (raw)
In-Reply-To: <20141212132321.GI11764@sirena.org.uk>
Hi Mark,
On 12/12/2014 09:23 PM, Mark Brown wrote:
> On Thu, Dec 11, 2014 at 11:14:39AM +0800, Bo Shen wrote:
>
>> +static const struct of_device_id wm8904_of_match[] = {
>> + { .compatible = "wlf,wm8904", },
>> + { .compatible = "wlf,wm8912", },
>> + { .compatible = "wlf,wm8918", },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, wm8904_of_match);
>> +
>> static struct i2c_driver wm8904_i2c_driver = {
>> .driver = {
>> .name = "wm8904",
>> .owner = THIS_MODULE,
>> + .of_match_table = wm8904_of_match,
>
> I'm not seeing anything here that ensures that devtype is set correctly
> when probing using the OF IDs - currently we rely on i2c->driver_data.
>
I will add it in v2 patch.
Thanks.
Best Regards,
Bo Shen
prev parent reply other threads:[~2014-12-15 3:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 3:14 [PATCH 1/3] ASoC: codecs: wm8904: add dt ids table Bo Shen
2014-12-11 3:14 ` [PATCH 2/3] ARM: at91: sama5d3xek/dt: use dt ids for wm8904 Bo Shen
2014-12-11 3:14 ` [PATCH 3/3] ARM: at91: at91sam9n12ek/dt: " Bo Shen
2014-12-12 13:23 ` [PATCH 1/3] ASoC: codecs: wm8904: add dt ids table Mark Brown
2014-12-15 3:28 ` Bo Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548E5554.6050900@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux@meltdown.ru \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).