From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kuankuan.Yang" Subject: Re: [PATCH 5/6] dt-bindings: Add documentation for Rockchip hdmi-audio Date: Mon, 15 Dec 2014 17:46:35 +0800 Message-ID: <548EADFB.6020903@rock-chips.com> References: <1418609494-15820-1-git-send-email-ykk@rock-chips.com> <1418612114-19692-1-git-send-email-ykk@rock-chips.com> <548EA3B9.5080407@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <548EA3B9.5080407-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen Cc: Heiko Stuebner , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Philipp Zabel , Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org, Fabio Estevam , Shawn Guo , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Daniel Kurtz , Sonny Rao , Dylan Reid , Xu Jianqun , =?UTF-8?B?U3Tvv73vv71waGFuZSBNYXJjaGVzaW4=?= , Brian Austin , Bard Liao , Max Filippov , Oder Chiou , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel@lists List-Id: devicetree@vger.kernel.org Hi lars: thks for your review, I will move it to hdmi audio driver, give the=20 codec_name & codec_dai_name an const string. Best Regards. =E5=9C=A8 2014=E5=B9=B412=E6=9C=8815=E6=97=A5 17:02, Lars-Peter Clausen= =E5=86=99=E9=81=93: > On 12/15/2014 03:55 AM, Yakir Yang wrote: > [...] >> +- codec-name: the dw-hdmi codec's device name >> +- codec-dai-name: the dw-hdmi codec's dai name > > Please you phandles for this, the names are Linux driver and framewor= k=20 > specific details. That should not leak into the DT bindings. > > [..] > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html