From mboxrd@z Thu Jan 1 00:00:00 1970 From: Josh Wu Subject: Re: [PATCH 6/7] ARM: at91: dts: sama5d3: add ov2640 camera sensor support Date: Mon, 22 Dec 2014 15:06:07 +0800 Message-ID: <5497C2DF.2040202@atmel.com> References: <1418892667-27428-1-git-send-email-josh.wu@atmel.com> <1418892667-27428-7-git-send-email-josh.wu@atmel.com> <20141219210509.GC4885@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141219210509.GC4885@piout.net> Sender: linux-media-owner@vger.kernel.org To: Alexandre Belloni Cc: nicolas.ferre@atmel.com, voice.shen@atmel.com, plagnioj@jcrosoft.com, boris.brezillon@free-electrons.com, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-media@vger.kernel.org, g.liakhovetski@gmx.de, laurent.pinchart@ideasonboard.com List-Id: devicetree@vger.kernel.org Hi, Alexandre Thanks for the review. On 12/20/2014 5:05 AM, Alexandre Belloni wrote: > On 18/12/2014 at 16:51:06 +0800, Josh Wu wrote : >> According to v4l2 dt document, we add: >> a camera host: ISI port. >> a i2c camera sensor: ov2640 port. >> to sama5d3xmb.dtsi. >> >> In the ov2640 node, it defines the pinctrls, clocks and isi port. >> In the ISI node, it also reference to a ov2640 port. >> >> Signed-off-by: Josh Wu >> --- >> arch/arm/boot/dts/sama5d3xmb.dtsi | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi b/arch/arm/boot/dts/sama5d3xmb.dtsi >> index 0aaebc6..958a528 100644 >> --- a/arch/arm/boot/dts/sama5d3xmb.dtsi >> +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi >> @@ -52,6 +52,29 @@ >> }; >> }; >> >> + i2c1: i2c@f0018000 { >> + ov2640: camera@0x30 { >> + compatible = "ovti,ov2640"; >> + reg = <0x30>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_isi_pck_as_mck &pinctrl_sensor_power &pinctrl_sensor_reset>; > I've acked your previous patch but maybe it should be named > pinctrl_isi_pck1_as_mck to be clearer (you used the handle to pck1 > below). It's a good idea. Maybe I prefer to use the name: pinctrl_pck1_as_isi_mck ? If you are ok with this name, in next version, I will add one more patch in the series to do this. And I will keep your acked-by in my previous patch. Best Regards, Josh Wu > >> + resetb-gpios = <&pioE 24 GPIO_ACTIVE_LOW>; >> + pwdn-gpios = <&pioE 29 GPIO_ACTIVE_HIGH>; >> + /* use pck1 for the master clock of ov2640 */ >> + clocks = <&pck1>; >> + clock-names = "xvclk"; >> + assigned-clocks = <&pck1>; >> + assigned-clock-rates = <25000000>; >> + >> + port { >> + ov2640_0: endpoint { >> + remote-endpoint = <&isi_0>; >> + bus-width = <8>; >> + }; >> + }; >> + }; >> + }; >> + >> usart1: serial@f0020000 { >> dmas = <0>, <0>; /* Do not use DMA for usart1 */ >> pinctrl-names = "default"; >> @@ -60,6 +83,15 @@ >> }; >> >> isi: isi@f0034000 { >> + port { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + isi_0: endpoint { >> + remote-endpoint = <&ov2640_0>; >> + bus-width = <8>; >> + }; >> + }; >> }; >> >> mmc1: mmc@f8000000 { >> -- >> 1.9.1 >>