* [PATCH 0/2] Add pinctrl support for audio IPs on exynos7 @ 2014-12-19 13:10 Padmavathi Venna 2014-12-19 13:10 ` [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 Padmavathi Venna 2014-12-19 13:10 ` [PATCH 2/2] arm64: dts: Add pinctrl support for audio IPs on exynos7 Padmavathi Venna 0 siblings, 2 replies; 7+ messages in thread From: Padmavathi Venna @ 2014-12-19 13:10 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree Cc: kgene.kim, linus.walleij, tomasz.figa, s.nawrocki Audio interface IPs I2S, PCM and SPDIF on Exynos7 requires GPIOs available on AUD and BUS0 pin controller blocks. So add support for all. This patchset is dependent on BUS1 pin control support from Vivek in the below link https://patchwork.kernel.org/patch/5467321/ Padmavathi Venna (2): pinctrl: exynos: Add AUDIO pin controller for exynos7 arm64: dts: Add pinctrl support for audio IPs on exynos7 .../bindings/pinctrl/samsung-pinctrl.txt | 1 + arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 56 ++++++++++++++++++++ arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 +++ drivers/pinctrl/samsung/pinctrl-exynos.c | 10 ++++ 4 files changed, 74 insertions(+), 0 deletions(-) -- 1.7.4.4 ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 2014-12-19 13:10 [PATCH 0/2] Add pinctrl support for audio IPs on exynos7 Padmavathi Venna @ 2014-12-19 13:10 ` Padmavathi Venna 2014-12-28 11:24 ` Tomasz Figa [not found] ` <1418994659-5222-2-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 2014-12-19 13:10 ` [PATCH 2/2] arm64: dts: Add pinctrl support for audio IPs on exynos7 Padmavathi Venna 1 sibling, 2 replies; 7+ messages in thread From: Padmavathi Venna @ 2014-12-19 13:10 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree Cc: kgene.kim, linus.walleij, tomasz.figa, s.nawrocki Audio IPs on Exynos7 require gpios available in AUDIO pin controller block. So adding the AUDIO pinctrl support. Signed-off-by: Padmavathi Venna <padma.v@samsung.com> --- .../bindings/pinctrl/samsung-pinctrl.txt | 1 + drivers/pinctrl/samsung/pinctrl-exynos.c | 10 ++++++++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt index c88ba35..9d2a995 100644 --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt @@ -181,6 +181,7 @@ Aliases for controllers compatible with "samsung,exynos7-pinctrl": - pinctrl6: pin controller of FSYS0 block, - pinctrl7: pin controller of FSYS1 block, - pinctrl8: pin controller of BUS1 block, +- pinctrl9: pin controller of AUDIO block, Example: A pin-controller node with pin banks: diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c index 2a85cb4..c8f83f9 100644 --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -1314,6 +1314,11 @@ static const struct samsung_pin_bank_data exynos7_pin_banks8[] __initconst = { EXYNOS_PIN_BANK_EINTG(3, 0x140, "gpv6", 0x24), }; +static const struct samsung_pin_bank_data exynos7_pin_banks9[] __initconst = { + EXYNOS_PIN_BANK_EINTG(7, 0x000, "gpz0", 0x00), + EXYNOS_PIN_BANK_EINTG(4, 0x020, "gpz1", 0x04), +}; + const struct samsung_pin_ctrl exynos7_pin_ctrl[] __initconst = { { /* pin-controller instance 0 Alive data */ @@ -1361,5 +1366,10 @@ const struct samsung_pin_ctrl exynos7_pin_ctrl[] __initconst = { .pin_banks = exynos7_pin_banks8, .nr_banks = ARRAY_SIZE(exynos7_pin_banks8), .eint_gpio_init = exynos_eint_gpio_init, + }, { + /* pin-controller instance 9 AUD data */ + .pin_banks = exynos7_pin_banks9, + .nr_banks = ARRAY_SIZE(exynos7_pin_banks9), + .eint_gpio_init = exynos_eint_gpio_init, }, }; -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 2014-12-19 13:10 ` [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 Padmavathi Venna @ 2014-12-28 11:24 ` Tomasz Figa [not found] ` <1418994659-5222-2-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> 1 sibling, 0 replies; 7+ messages in thread From: Tomasz Figa @ 2014-12-28 11:24 UTC (permalink / raw) To: Padmavathi Venna, linux-arm-kernel, linux-samsung-soc, devicetree Cc: kgene.kim, linus.walleij, s.nawrocki On 19.12.2014 22:10, Padmavathi Venna wrote: > Audio IPs on Exynos7 require gpios available in AUDIO > pin controller block. So adding the AUDIO pinctrl support. > > Signed-off-by: Padmavathi Venna <padma.v@samsung.com> > --- > .../bindings/pinctrl/samsung-pinctrl.txt | 1 + > drivers/pinctrl/samsung/pinctrl-exynos.c | 10 ++++++++++ > 2 files changed, 11 insertions(+), 0 deletions(-) Acked-by: Tomasz Figa <tomasz.figa@gmail.com> Best regards, Tomasz ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <1418994659-5222-2-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>]
* Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 [not found] ` <1418994659-5222-2-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> @ 2015-01-14 11:40 ` Linus Walleij 2015-01-14 14:27 ` Tomasz Figa 0 siblings, 1 reply; 7+ messages in thread From: Linus Walleij @ 2015-01-14 11:40 UTC (permalink / raw) To: Padmavathi Venna Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim, Tomasz Figa, Sylwester Nawrocki On Fri, Dec 19, 2014 at 2:10 PM, Padmavathi Venna <padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: > Audio IPs on Exynos7 require gpios available in AUDIO > pin controller block. So adding the AUDIO pinctrl support. > > Signed-off-by: Padmavathi Venna <padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> (...) > --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > @@ -181,6 +181,7 @@ Aliases for controllers compatible with "samsung,exynos7-pinctrl": > - pinctrl6: pin controller of FSYS0 block, > - pinctrl7: pin controller of FSYS1 block, > - pinctrl8: pin controller of BUS1 block, > +- pinctrl9: pin controller of AUDIO block, This doesn't apply at all, the list has never been in the document merged upstream. Please prepare this patch rebased on a *CLEAN* upstream tree and resend. Include Tomasz ACK on your repost. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 2015-01-14 11:40 ` Linus Walleij @ 2015-01-14 14:27 ` Tomasz Figa [not found] ` <CA+Ln22GhnW5jcXdQfYaJ_aM4Wq9OHXvShHHaxLKjJi+dp6Afcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 7+ messages in thread From: Tomasz Figa @ 2015-01-14 14:27 UTC (permalink / raw) To: Linus Walleij Cc: Padmavathi Venna, linux-arm-kernel@lists.infradead.org, linux-samsung-soc, devicetree@vger.kernel.org, Kukjin Kim, Sylwester Nawrocki Hi Linus, 2015-01-14 20:40 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>: > On Fri, Dec 19, 2014 at 2:10 PM, Padmavathi Venna <padma.v@samsung.com> wrote: > >> Audio IPs on Exynos7 require gpios available in AUDIO >> pin controller block. So adding the AUDIO pinctrl support. >> >> Signed-off-by: Padmavathi Venna <padma.v@samsung.com> > (...) >> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >> @@ -181,6 +181,7 @@ Aliases for controllers compatible with "samsung,exynos7-pinctrl": >> - pinctrl6: pin controller of FSYS0 block, >> - pinctrl7: pin controller of FSYS1 block, >> - pinctrl8: pin controller of BUS1 block, >> +- pinctrl9: pin controller of AUDIO block, > > This doesn't apply at all, the list has never been in the document merged > upstream. I believe this patch depends on patch [1], which was mentioned in cover letter and which you seem to have applied two days ago. If it still doesn't apply, please let me know if I should collect the patches myself and prepare a pull request for you. [1] https://patchwork.kernel.org/patch/5467321/ Best regards, Tomasz ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CA+Ln22GhnW5jcXdQfYaJ_aM4Wq9OHXvShHHaxLKjJi+dp6Afcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 [not found] ` <CA+Ln22GhnW5jcXdQfYaJ_aM4Wq9OHXvShHHaxLKjJi+dp6Afcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2015-01-19 10:05 ` Linus Walleij 0 siblings, 0 replies; 7+ messages in thread From: Linus Walleij @ 2015-01-19 10:05 UTC (permalink / raw) To: Tomasz Figa Cc: Padmavathi Venna, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-samsung-soc, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim, Sylwester Nawrocki On Wed, Jan 14, 2015 at 3:27 PM, Tomasz Figa <tomasz.figa-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: > 2015-01-14 20:40 GMT+09:00 Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>: >> On Fri, Dec 19, 2014 at 2:10 PM, Padmavathi Venna <padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote: >> >>> Audio IPs on Exynos7 require gpios available in AUDIO >>> pin controller block. So adding the AUDIO pinctrl support. >>> >>> Signed-off-by: Padmavathi Venna <padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> >> (...) >>> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >>> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt >>> @@ -181,6 +181,7 @@ Aliases for controllers compatible with "samsung,exynos7-pinctrl": >>> - pinctrl6: pin controller of FSYS0 block, >>> - pinctrl7: pin controller of FSYS1 block, >>> - pinctrl8: pin controller of BUS1 block, >>> +- pinctrl9: pin controller of AUDIO block, >> >> This doesn't apply at all, the list has never been in the document merged >> upstream. > > I believe this patch depends on patch [1], which was mentioned in > cover letter and which you seem to have applied two days ago. If it > still doesn't apply, please let me know if I should collect the > patches myself and prepare a pull request for you. > > [1] https://patchwork.kernel.org/patch/5467321/ It applied when I tried it now, sorry I must have screwed up or something :( Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: Add pinctrl support for audio IPs on exynos7 2014-12-19 13:10 [PATCH 0/2] Add pinctrl support for audio IPs on exynos7 Padmavathi Venna 2014-12-19 13:10 ` [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 Padmavathi Venna @ 2014-12-19 13:10 ` Padmavathi Venna 1 sibling, 0 replies; 7+ messages in thread From: Padmavathi Venna @ 2014-12-19 13:10 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree Cc: kgene.kim, linus.walleij, tomasz.figa, s.nawrocki Add pinctrl support for I2S,PCM,SPDIF Signed-off-by: Padmavathi Venna <padma.v@samsung.com> --- arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 56 +++++++++++++++++++++++ arch/arm64/boot/dts/exynos/exynos7.dtsi | 7 +++ 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi index c367f0a..a5aeb07 100644 --- a/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi @@ -333,6 +333,29 @@ samsung,pin-pud = <3>; samsung,pin-drv = <0>; }; + + i2s1_bus: i2s1-bus { + samsung,pins = "gpd4-0", "gpd4-1", "gpd4-2", + "gpd4-3", "gpd4-4"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <0>; + }; + + pcm1_bus: pcm1-bus { + samsung,pins = "gpd4-0", "gpd4-2", + "gpd4-3", "gpd4-4"; + samsung,pin-function = <3>; + samsung,pin-pud = <1>; + samsung,pin-drv = <0>; + }; + + spdif_bus: spdif-bus { + samsung,pins = "gpd4-3", "gpd4-4"; + samsung,pin-function = <4>; + samsung,pin-pud = <1>; + samsung,pin-drv = <0>; + }; }; &pinctrl_bus1 { @@ -668,3 +691,36 @@ samsung,pin-drv = <2>; }; }; + +&pinctrl_aud { + gpz0: gpz0 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + gpz1: gpz1 { + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + }; + + i2s0_bus: i2s0-bus { + samsung,pins = "gpz0-0", "gpz0-1", "gpz0-2", "gpz0-3", + "gpz0-4"; + samsung,pin-function = <2>; + samsung,pin-pud = <1>; + samsung,pin-drv = <0>; + }; + + pcm0_bus: pcm0-bus { + samsung,pins = "gpz1-0", "gpz1-1", "gpz1-2", "gpz1-3"; + samsung,pin-function = <5>; + samsung,pin-pud = <1>; + samsung,pin-drv = <0>; + }; +}; diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index e633b02..eeaa9b8d 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -27,6 +27,7 @@ pinctrl6 = &pinctrl_fsys0; pinctrl7 = &pinctrl_fsys1; pinctrl8 = &pinctrl_bus1; + pinctrl9 = &pinctrl_aud; }; cpus { @@ -285,6 +286,12 @@ interrupts = <0 203 0>; }; + pinctrl_aud: pinctrl@114b0000 { + compatible = "samsung,exynos7-pinctrl"; + reg = <0x114b0000 0x1000>; + interrupts = <0 92 0>; + }; + hsi2c_0: hsi2c@13640000 { compatible = "samsung,exynos7-hsi2c"; reg = <0x13640000 0x1000>; -- 1.7.4.4 ^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-01-19 10:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 13:10 [PATCH 0/2] Add pinctrl support for audio IPs on exynos7 Padmavathi Venna
2014-12-19 13:10 ` [PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7 Padmavathi Venna
2014-12-28 11:24 ` Tomasz Figa
[not found] ` <1418994659-5222-2-git-send-email-padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-14 11:40 ` Linus Walleij
2015-01-14 14:27 ` Tomasz Figa
[not found] ` <CA+Ln22GhnW5jcXdQfYaJ_aM4Wq9OHXvShHHaxLKjJi+dp6Afcg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-19 10:05 ` Linus Walleij
2014-12-19 13:10 ` [PATCH 2/2] arm64: dts: Add pinctrl support for audio IPs on exynos7 Padmavathi Venna
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).