* [PATCH v2 0/2] Pinctrl: add amlogic a5 pinctrl node
@ 2025-04-01 2:06 Xianwei Zhao via B4 Relay
2025-04-01 2:06 ` [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 Xianwei Zhao via B4 Relay
2025-04-01 2:06 ` [PATCH v2 2/2] dts: arm64: amlogic: add a5 pinctrl node Xianwei Zhao via B4 Relay
0 siblings, 2 replies; 5+ messages in thread
From: Xianwei Zhao via B4 Relay @ 2025-04-01 2:06 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: linux-amlogic, linux-gpio, devicetree, linux-kernel,
linux-arm-kernel, Xianwei Zhao, Conor Dooley
Add A5 pinctrl compatible string and device node.
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
Changes in v2:
- Modify bindings according to Conor's suggestion.
- Link to v1: https://lore.kernel.org/r/20250327-a5-pinctrl-v1-0-49320349c463@amlogic.com
---
Xianwei Zhao (2):
dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5
dts: arm64: amlogic: add a5 pinctrl node
.../bindings/pinctrl/amlogic,pinctrl-a4.yaml | 8 +-
arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi | 90 ++++++++++++++++++++++
2 files changed, 96 insertions(+), 2 deletions(-)
---
base-commit: 79e0ecfc780aaf8c0b6658607f75a661a5f00736
change-id: 20250318-a5-pinctrl-f3c6c6aa0e7f
Best regards,
--
Xianwei Zhao <xianwei.zhao@amlogic.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 2025-04-01 2:06 [PATCH v2 0/2] Pinctrl: add amlogic a5 pinctrl node Xianwei Zhao via B4 Relay @ 2025-04-01 2:06 ` Xianwei Zhao via B4 Relay 2025-04-01 6:13 ` Krzysztof Kozlowski 2025-04-01 2:06 ` [PATCH v2 2/2] dts: arm64: amlogic: add a5 pinctrl node Xianwei Zhao via B4 Relay 1 sibling, 1 reply; 5+ messages in thread From: Xianwei Zhao via B4 Relay @ 2025-04-01 2:06 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl Cc: linux-amlogic, linux-gpio, devicetree, linux-kernel, linux-arm-kernel, Xianwei Zhao, Conor Dooley From: Xianwei Zhao <xianwei.zhao@amlogic.com> Amlogic A5 SoCs uses the same pintrl controller as A4 SoCs. There is no need for an extra compatible line in the driver, but add A5 compatible line for documentation. Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> --- Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml index 8eb50cad61d5..3bebccaf0c9f 100644 --- a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml @@ -14,8 +14,12 @@ allOf: properties: compatible: - const: amlogic,pinctrl-a4 - + oneOf: + - const: amlogic,pinctrl-a4 + - items: + - enum: + - amlogic,pinctrl-a5 + - const: amlogic,pinctrl-a4 "#address-cells": const: 2 -- 2.37.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 2025-04-01 2:06 ` [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 Xianwei Zhao via B4 Relay @ 2025-04-01 6:13 ` Krzysztof Kozlowski 2025-04-01 6:37 ` Xianwei Zhao 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2025-04-01 6:13 UTC (permalink / raw) To: Xianwei Zhao Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, linux-amlogic, linux-gpio, devicetree, linux-kernel, linux-arm-kernel, Conor Dooley On Tue, Apr 01, 2025 at 10:06:21AM +0800, Xianwei Zhao wrote: > Amlogic A5 SoCs uses the same pintrl controller as A4 SoCs. There is > no need for an extra compatible line in the driver, but add A5 > compatible line for documentation. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> > --- > Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml > index 8eb50cad61d5..3bebccaf0c9f 100644 > --- a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml > @@ -14,8 +14,12 @@ allOf: > > properties: > compatible: > - const: amlogic,pinctrl-a4 > - Do not remove blank line. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 2025-04-01 6:13 ` Krzysztof Kozlowski @ 2025-04-01 6:37 ` Xianwei Zhao 0 siblings, 0 replies; 5+ messages in thread From: Xianwei Zhao @ 2025-04-01 6:37 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl, linux-amlogic, linux-gpio, devicetree, linux-kernel, linux-arm-kernel, Conor Dooley Hi Krzysztof, Thanks for your review. On 2025/4/1 14:13, Krzysztof Kozlowski wrote: > [ EXTERNAL EMAIL ] > > On Tue, Apr 01, 2025 at 10:06:21AM +0800, Xianwei Zhao wrote: >> Amlogic A5 SoCs uses the same pintrl controller as A4 SoCs. There is >> no need for an extra compatible line in the driver, but add A5 >> compatible line for documentation. >> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> >> --- >> Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml | 8 ++++++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml >> index 8eb50cad61d5..3bebccaf0c9f 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/amlogic,pinctrl-a4.yaml >> @@ -14,8 +14,12 @@ allOf: >> >> properties: >> compatible: >> - const: amlogic,pinctrl-a4 >> - > > Do not remove blank line. > Will fix. > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dts: arm64: amlogic: add a5 pinctrl node 2025-04-01 2:06 [PATCH v2 0/2] Pinctrl: add amlogic a5 pinctrl node Xianwei Zhao via B4 Relay 2025-04-01 2:06 ` [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 Xianwei Zhao via B4 Relay @ 2025-04-01 2:06 ` Xianwei Zhao via B4 Relay 1 sibling, 0 replies; 5+ messages in thread From: Xianwei Zhao via B4 Relay @ 2025-04-01 2:06 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl Cc: linux-amlogic, linux-gpio, devicetree, linux-kernel, linux-arm-kernel, Xianwei Zhao From: Xianwei Zhao <xianwei.zhao@amlogic.com> Add pinctrl device to support Amlogic A5. Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com> --- arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi | 90 +++++++++++++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi index 32ed1776891b..844302db2133 100644 --- a/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi +++ b/arch/arm64/boot/dts/amlogic/amlogic-a5.dtsi @@ -4,6 +4,7 @@ */ #include "amlogic-a4-common.dtsi" +#include <dt-bindings/pinctrl/amlogic,pinctrl.h> #include <dt-bindings/power/amlogic,a5-pwrc.h> / { cpus { @@ -50,6 +51,95 @@ pwrc: power-controller { }; &apb { + periphs_pinctrl: pinctrl@4000 { + compatible = "amlogic,pinctrl-a5", + "amlogic,pinctrl-a4"; + #address-cells = <2>; + #size-cells = <2>; + ranges = <0x0 0x0 0x0 0x4000 0x0 0x300>; + + gpioz: gpio@c0 { + reg = <0x0 0xc0 0x0 0x40>, + <0x0 0x18 0x0 0x8>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_Z<<8) 16>; + }; + + gpiox: gpio@100 { + reg = <0x0 0x100 0x0 0x40>, + <0x0 0xc 0x0 0xc>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_X<<8) 20>; + }; + + gpiot: gpio@140 { + reg = <0x0 0x140 0x0 0x40>, + <0x0 0x2c 0x0 0x8>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_T<<8) 14>; + }; + + gpiod: gpio@180 { + reg = <0x0 0x180 0x0 0x40>, + <0x0 0x40 0x0 0x8>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_D<<8) 16>; + }; + + gpioe: gpio@1c0 { + reg = <0x0 0x1c0 0x0 0x40>, + <0x0 0x48 0x0 0x4>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_E<<8) 2>; + }; + + gpioc: gpio@200 { + reg = <0x0 0x200 0x0 0x40>, + <0x0 0x24 0x0 0x8>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_C<<8) 11>; + }; + + gpiob: gpio@240 { + reg = <0x0 0x240 0x0 0x40>, + <0x0 0x0 0x0 0x8>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_B<<8) 14>; + }; + + gpioh: gpio@280 { + reg = <0x0 0x280 0x0 0x40>, + <0x0 0x4c 0x0 0x4>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_H<<8) 5>; + }; + + gpio_test_n: gpio@2c0 { + reg = <0x0 0x2c0 0x0 0x40>, + <0x0 0x3c 0x0 0x4>; + reg-names = "gpio", "mux"; + gpio-controller; + #gpio-cells = <2>; + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>; + }; + }; + gpio_intc: interrupt-controller@4080 { compatible = "amlogic,a5-gpio-intc", "amlogic,meson-gpio-intc"; -- 2.37.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-04-01 6:37 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-04-01 2:06 [PATCH v2 0/2] Pinctrl: add amlogic a5 pinctrl node Xianwei Zhao via B4 Relay 2025-04-01 2:06 ` [PATCH v2 1/2] dt-bindings: pinctl: amlogic,pinctrl-a4: Add compatible string for A5 Xianwei Zhao via B4 Relay 2025-04-01 6:13 ` Krzysztof Kozlowski 2025-04-01 6:37 ` Xianwei Zhao 2025-04-01 2:06 ` [PATCH v2 2/2] dts: arm64: amlogic: add a5 pinctrl node Xianwei Zhao via B4 Relay
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).