From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use Date: Tue, 30 Dec 2014 15:39:48 +0300 Message-ID: <54A29D14.6000705@cogentembedded.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andrew Jackson , Jaroslav Kysela , Takashi Iwai , Mark Brown Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Lars-Peter Clausen , pawel.moll@arm.com, Arnd Bergmann , ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, Liviu Dudau , Liam Girdwood , Rajeev Kumar , robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello. On 12/30/2014 1:55 PM, Andrew Jackson wrote: > From: Andrew Jackson > Some I2S clocks may require some time to get the clock ready > for operation and so need to be prepared before they are enabled. > So, prepare the clock as well as enabling it, but combine the > two through clk_prepare_enable. > Signed-off-by: Andrew Jackson > --- > sound/soc/dwc/designware_i2s.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) > diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c > index 5e9d163..08608c1 100644 > --- a/sound/soc/dwc/designware_i2s.c > +++ b/sound/soc/dwc/designware_i2s.c [...] > @@ -426,13 +426,16 @@ static int dw_i2s_probe(struct platform_device *pdev) [...] > static int dw_i2s_remove(struct platform_device *pdev) > { > + struct dw_i2s_dev *dev = dev_get_drvdata(&pdev->dev); Why not just platform_get_drvdata(pdev)? [...] WBR, Sergei