[PATCH RESEND 0/2] ARM: dts: exynos3250: revise property for gpio-keys node

[PATCH RESEND 0/2] ARM: dts: exynos3250: revise property for gpio-keys node

[Beomho Seo]

This patch revises property of gpio-keys node.
The first patch remove unecessary property.
And then, replace by macro in gpio keys.

Beomho Seo (2):
  ARM: dts: exynos3250: remove unecessary property of gpio-keys node
  ARM: dts: exynos3250: replace number by macro in gpio keys

 arch/arm/boot/dts/exynos3250-monk.dts   |    5 ++---
 arch/arm/boot/dts/exynos3250-rinato.dts |    5 ++---
 2 files changed, 4 insertions(+), 6 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RESEND 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node

[Beomho Seo]

This patch remove unecessary property of gpio-keys node.
gpio-keys driver do not uses interrupts and interrupt-parent.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Youngjun Cho <yj44.cho@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
 arch/arm/boot/dts/exynos3250-monk.dts   |    2 --
 arch/arm/boot/dts/exynos3250-rinato.dts |    2 --
 2 files changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 24822aa..2129ab98 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -37,8 +37,6 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			interrupt-parent = <&gpx2>;
-			interrupts = <7 0>;
 			gpios = <&gpx2 7 1>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index 80aa8b4..c186ac6 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -37,8 +37,6 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			interrupt-parent = <&gpx2>;
-			interrupts = <7 0>;
 			gpios = <&gpx2 7 1>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
-- 
1.7.9.5

[PATCH RESEND 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys

[Beomho Seo]

This patch replace number by macro in gpio keys for exynos 3250 boards.

Cc: Kukjin Kim <kgene@kernel.org>
Cc: Youngjun Cho <yj44.cho@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
---
 arch/arm/boot/dts/exynos3250-monk.dts   |    3 ++-
 arch/arm/boot/dts/exynos3250-rinato.dts |    3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
index 2129ab98..792a2c7 100644
--- a/arch/arm/boot/dts/exynos3250-monk.dts
+++ b/arch/arm/boot/dts/exynos3250-monk.dts
@@ -15,6 +15,7 @@
 /dts-v1/;
 #include "exynos3250.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Samsung Monk board";
@@ -37,7 +38,7 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			gpios = <&gpx2 7 1>;
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
 			debounce-interval = <10>;
diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
index c186ac6..3493bca 100644
--- a/arch/arm/boot/dts/exynos3250-rinato.dts
+++ b/arch/arm/boot/dts/exynos3250-rinato.dts
@@ -15,6 +15,7 @@
 /dts-v1/;
 #include "exynos3250.dtsi"
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/gpio/gpio.h>
 
 / {
 	model = "Samsung Rinato board";
@@ -37,7 +38,7 @@
 		compatible = "gpio-keys";
 
 		power_key {
-			gpios = <&gpx2 7 1>;
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_POWER>;
 			label = "power key";
 			debounce-interval = <10>;
-- 
1.7.9.5

Re: [PATCH RESEND 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node

[Kukjin Kim]

On 01/06/15 12:43, Beomho Seo wrote:
> This patch remove unecessary property of gpio-keys node.

The checkpatch complains like 'perhaps 'unnecessary'?' ;)

Applied this and 2nd one.

Thanks,
Kukjin

> gpio-keys driver do not uses interrupts and interrupt-parent.
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Youngjun Cho <yj44.cho@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>  arch/arm/boot/dts/exynos3250-monk.dts   |    2 --
>  arch/arm/boot/dts/exynos3250-rinato.dts |    2 --
>  2 files changed, 4 deletions(-)