* [PATCH] ARM: shmobile: r8a7791: fix MSTP8 input clocks
@ 2015-01-12 22:31 Sergei Shtylyov
2015-01-13 0:36 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2015-01-12 22:31 UTC (permalink / raw)
To: horms, linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak
Cc: magnus.damm, linux, linux-arm-kernel
I made a mistake when rebasing Andrey Gusakov's patch adding MLB+ clock to the
R8A7791 device tree, inserting <&hp_clk> into the "clocks" property of the
MSTP8 node at a wrong position, so that the input clocks for MLB+ and IPMMU-SGX
got swapped...
Fixes: 7408d3061d2f ("ARM: shmobile: r8a7791: add MLB+ clock")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
The patch is against 'renesas-devel-20150108v2-v3.19-rc3' tag of Simon Horman's
'renesas.git' repo.
arch/arm/boot/dts/r8a7791.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
===================================================================
--- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
+++ renesas/arch/arm/boot/dts/r8a7791.dtsi
@@ -1196,7 +1196,7 @@
mstp8_clks: mstp8_clks@e6150990 {
compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
- clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,
+ clocks = <&zg_clk>, <&hp_clk>, <&zg_clk>, <&zg_clk>,
<&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
#clock-cells = <1>;
clock-indices = <
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: r8a7791: fix MSTP8 input clocks
2015-01-12 22:31 [PATCH] ARM: shmobile: r8a7791: fix MSTP8 input clocks Sergei Shtylyov
@ 2015-01-13 0:36 ` Simon Horman
2015-01-14 19:00 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2015-01-13 0:36 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
On Tue, Jan 13, 2015 at 01:31:14AM +0300, Sergei Shtylyov wrote:
> I made a mistake when rebasing Andrey Gusakov's patch adding MLB+ clock to the
> R8A7791 device tree, inserting <&hp_clk> into the "clocks" property of the
> MSTP8 node at a wrong position, so that the input clocks for MLB+ and IPMMU-SGX
> got swapped...
>
> Fixes: 7408d3061d2f ("ARM: shmobile: r8a7791: add MLB+ clock")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against 'renesas-devel-20150108v2-v3.19-rc3' tag of Simon Horman's
> 'renesas.git' repo.
Thanks, I have queued this up.
>
> arch/arm/boot/dts/r8a7791.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: renesas/arch/arm/boot/dts/r8a7791.dtsi
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7791.dtsi
> +++ renesas/arch/arm/boot/dts/r8a7791.dtsi
> @@ -1196,7 +1196,7 @@
> mstp8_clks: mstp8_clks@e6150990 {
> compatible = "renesas,r8a7791-mstp-clocks", "renesas,cpg-mstp-clocks";
> reg = <0 0xe6150990 0 4>, <0 0xe61509a0 0 4>;
> - clocks = <&hp_clk>, <&zg_clk>, <&zg_clk>, <&zg_clk>,
> + clocks = <&zg_clk>, <&hp_clk>, <&zg_clk>, <&zg_clk>,
> <&zg_clk>, <&p_clk>, <&zs_clk>, <&zs_clk>;
> #clock-cells = <1>;
> clock-indices = <
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: r8a7791: fix MSTP8 input clocks
2015-01-13 0:36 ` Simon Horman
@ 2015-01-14 19:00 ` Sergei Shtylyov
0 siblings, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2015-01-14 19:00 UTC (permalink / raw)
To: Simon Horman
Cc: linux-sh, devicetree, robh+dt, pawel.moll, mark.rutland,
ijc+devicetree, galak, magnus.damm, linux, linux-arm-kernel
Hello.
On 01/13/2015 03:36 AM, Simon Horman wrote:
>> I made a mistake when rebasing Andrey Gusakov's patch adding MLB+ clock to the
>> R8A7791 device tree, inserting <&hp_clk> into the "clocks" property of the
>> MSTP8 node at a wrong position, so that the input clocks for MLB+ and IPMMU-SGX
>> got swapped...
>> Fixes: 7408d3061d2f ("ARM: shmobile: r8a7791: add MLB+ clock")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> The patch is against 'renesas-devel-20150108v2-v3.19-rc3' tag of Simon Horman's
>> 'renesas.git' repo.
> Thanks, I have queued this up.
Thank you! I've just noticed that this patch was atop of several other
patches in my tree, so there might have been an offset when you applied it.
Sorry about that... :-<
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-14 19:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 22:31 [PATCH] ARM: shmobile: r8a7791: fix MSTP8 input clocks Sergei Shtylyov
2015-01-13 0:36 ` Simon Horman
2015-01-14 19:00 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).