From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH/RFC v10 17/19] DT: Add documentation for exynos4-is 'flashes' property Date: Wed, 21 Jan 2015 17:32:57 +0100 Message-ID: <54BFD4B9.8030707@samsung.com> References: <1420816989-1808-1-git-send-email-j.anaszewski@samsung.com> <1420816989-1808-18-git-send-email-j.anaszewski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1420816989-1808-18-git-send-email-j.anaszewski@samsung.com> Sender: linux-leds-owner@vger.kernel.org To: Jacek Anaszewski , linux-kernel@vger.kernel.org Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org Hi, On 09/01/15 16:23, Jacek Anaszewski wrote: > This patch adds a description of 'flashes' property > to the samsung-fimc.txt. > > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > --- > .../devicetree/bindings/media/samsung-fimc.txt | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt > index 922d6f8..22a6b2f 100644 > --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt > +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt > @@ -40,6 +40,12 @@ should be inactive. For the "active-a" state the camera port A must be activated > and the port B deactivated and for the state "active-b" it should be the other > way around. > > +Optional properties: > + > +- flashes - Array of phandles to flash LED devices, or their sub-nodes > + representing sub-leds. > + (see Documentation/devicetree/bindings/leds/common.txt) How about renaming this to "illuminators" or something else more generic? The "torch" LED (for video recording illumination?) is not really a flash. > + > The 'camera' node must include at least one 'fimc' child node. > > > @@ -166,6 +172,7 @@ Example: > clock-output-names = "cam_a_clkout", "cam_b_clkout"; > pinctrl-names = "default"; > pinctrl-0 = <&cam_port_a_clk_active>; > + flashes = <&camera_flash>, <&system_torch>; > status = "okay"; > #address-cells = <1>; > #size-cells = <1>; -- Thanks, Sylwester