From: Nathan Lynch <Nathan_Lynch@mentor.com>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
"Ohad Ben-Cohen" <ohad@wizery.com>,
"Antti Palosaari" <crope@iki.fi>,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Joe Perches" <joe@perches.com>,
devicetree@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Grant Likely" <grant.likely@linaro.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH 2/2] remoteproc: microblaze: Add support for microblaze on Zynq
Date: Thu, 22 Jan 2015 10:53:13 -0600 [thread overview]
Message-ID: <54C12AF9.40200@mentor.com> (raw)
In-Reply-To: <10276362c737fc9da863f1a07737fd91f7340242.1421662385.git.michal.simek@xilinx.com>
On 01/19/2015 04:30 AM, Michal Simek wrote:
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 5e343bab9458..3955f42e9e9c 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -64,4 +64,15 @@ config DA8XX_REMOTEPROC
> It's safe to say n here if you're not interested in multimedia
> offloading.
>
> +config MB_REMOTEPROC
> + tristate "Support Microblaze remoteproc"
> + depends on ARCH_ZYNQ && !DEBUG_SG
> + select GPIO_XILINX
> + select REMOTEPROC
> + select RPMSG
> + default m
> + help
> + Say y here to support Xilinx Microblaze remote processors
> + on the Xilinx Zynq.
> +
> endmenu
The dependency on !DEBUG_SG seems unusual, and worth a comment if it's
truly needed. And the module should be disabled by default, no?
next prev parent reply other threads:[~2015-01-22 16:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 10:30 [PATCH 1/2] remoteproc: microblaze: Document device tree bindings Michal Simek
[not found] ` <a458462d2dc6901440bded015608f7a9df9e7942.1421662385.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
2015-01-19 10:30 ` [PATCH 2/2] remoteproc: microblaze: Add support for microblaze on Zynq Michal Simek
2015-01-22 16:53 ` Nathan Lynch [this message]
2015-01-23 8:23 ` Michal Simek
2015-01-19 11:04 ` [PATCH 1/2] remoteproc: microblaze: Document device tree bindings Mark Rutland
2015-01-19 11:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C12AF9.40200@mentor.com \
--to=nathan_lynch@mentor.com \
--cc=akpm@linux-foundation.org \
--cc=crope@iki.fi \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).