From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 4/4] sound: jz4740: Enable codec clock during dai_probe Date: Mon, 26 Jan 2015 11:40:00 +0100 Message-ID: <54C61980.9030205@metafoo.de> References: <1422267511-6649-1-git-send-email-Zubair.Kakakhel@imgtec.com> <1422267511-6649-5-git-send-email-Zubair.Kakakhel@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1422267511-6649-5-git-send-email-Zubair.Kakakhel-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Zubair Lutfullah Kakakhel , tiwai-l3A5Bk7waGM@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org Cc: broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/26/2015 11:18 AM, Zubair Lutfullah Kakakhel wrote: > As we are moving away from platform to DT, we cant rely on the board > file to do this now. So enable it here. I don't understand this changelog. The board file never did this. The driver enables the clock in the startup() callback. > > Signed-off-by: Zubair Lutfullah Kakakhel > --- > sound/soc/jz4740/jz4740-i2s.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c > index 3c309fc..a7e4a7b 100644 > --- a/sound/soc/jz4740/jz4740-i2s.c > +++ b/sound/soc/jz4740/jz4740-i2s.c > @@ -376,6 +376,10 @@ static int jz4740_i2s_dai_probe(struct snd_soc_dai *dai) > JZ_AIC_CONF_I2S | > JZ_AIC_CONF_INTERNAL_CODEC; > > + /* enable codec sysclk */ > + clk_set_rate(i2s->clk_i2s, 12000000); > + clk_prepare_enable(i2s->clk_i2s); > + > jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, JZ_AIC_CONF_RESET); > jz4740_i2s_write(i2s, JZ_REG_AIC_CONF, conf); > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html