From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [RFC 2/2] sunxi: Initial Inet 86VS support. Date: Wed, 28 Jan 2015 11:11:06 +0100 Message-ID: <54C8B5BA.5010009@redhat.com> References: <54C8B3D2.8060601@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: <54C8B3D2.8060601-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Cc: Maxime Ripard , devicetree List-Id: devicetree@vger.kernel.org Hi, On 28-01-15 11:02, Hans de Goede wrote: > Hi, > > On 04-01-15 21:06, Michal Suchanek wrote: >> Signed-off-by: Michal Suchanek > > Thanks, I've merged this with a number of changes: > > - Cleaned it up a bit > - Ported it to our new simplified dram config code in u-boot-sunxi/next > - Added OTG (host mode) support, so that you can hookup a keyboard and > interact with u-boot (kernel otg host support is coming soonish too) > - Fixed the dtb name from sun5i-inet-86vs.dtb to sun5i-a13-inet-86vs.dtb > to match the upstream kernel dts / dtb naming scheme. Talking about upstream dts files, it would be great if you could officially submit one for the Inet 86VS upstream: 1) Drop any nand bits you may have in there as the nand code is not upstream yet 2) We've recently adapted a new style for upstream dts files, please reformat the dts you've accordingly, see e.g.: https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3 3) Write a proper commit message with a short description of the board, and be sure to add a Signed-off-by: Michal Suchanek 4) Be sure to send the patch directly to Maxime Ripard, with devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org in the Cc, you may Cc other people / lists too, but you must send it to those 2 addresses. Regards, Hans