Re: [RFC 2/2] sunxi: Initial Inet 86VS support.

Re: [RFC 2/2] sunxi: Initial Inet 86VS support.

[Hans de Goede]

Hi,

On 28-01-15 11:02, Hans de Goede wrote:
> Hi,
>
> On 04-01-15 21:06, Michal Suchanek wrote:
>> Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Thanks, I've merged this with a number of changes:
>
> - Cleaned it up a bit
> - Ported it to our new simplified dram config code in u-boot-sunxi/next
> - Added OTG (host mode) support, so that you can hookup a keyboard and
>    interact with u-boot (kernel otg host support is coming soonish too)
> - Fixed the dtb name from sun5i-inet-86vs.dtb to sun5i-a13-inet-86vs.dtb
>    to match the upstream kernel dts / dtb naming scheme.

Talking about upstream dts files, it would be great if you could officially
submit one for the Inet 86VS upstream:

1) Drop any nand bits you may have in there as the nand code is not upstream yet
2) We've recently adapted a new style for upstream dts files, please reformat
    the dts you've accordingly, see e.g.:
    https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3
3) Write a proper commit message with a short description of the board, and
    be sure to add a Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
4) Be sure to send the patch directly to Maxime Ripard, with devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
    in the Cc, you may Cc other people / lists too, but you must send it to
    those 2 addresses.

Regards,

Hans

Re: [RFC 2/2] sunxi: Initial Inet 86VS support.

[Michal Suchanek]

On 28 January 2015 at 11:11, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Hi,
>
> On 28-01-15 11:02, Hans de Goede wrote:
>>
>> Hi,
>>
>> On 04-01-15 21:06, Michal Suchanek wrote:
>>>
>>> Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>>
>> Thanks, I've merged this with a number of changes:
>>
>> - Cleaned it up a bit
>> - Ported it to our new simplified dram config code in u-boot-sunxi/next

Thanks for looking into this.

I don't really know what counts as 'clean' config. There are multiple
ways to specify an option and different configs use different ways.

>> - Added OTG (host mode) support, so that you can hookup a keyboard and
>>    interact with u-boot (kernel otg host support is coming soonish too)

I did not have OTG in my tree when writing this. Maybe I Should pull
some more patches.

>> - Fixed the dtb name from sun5i-inet-86vs.dtb to sun5i-a13-inet-86vs.dtb
>>    to match the upstream kernel dts / dtb naming scheme.
>

Speaking of testing

I use FEL to boot the new u-boot and kernel. What was the way to build
FEL spl since we have no separate FEL defconfigs?

And even if there is option to enable fel it does not change to SD
uart, does it?
It probably should not by default even on devices without uart but
selecting SD uart is required to have console.

>
> Talking about upstream dts files, it would be great if you could officially
> submit one for the Inet 86VS upstream:
>
> 1) Drop any nand bits you may have in there as the nand code is not upstream
> yet
> 2) We've recently adapted a new style for upstream dts files, please
> reformat
>    the dts you've accordingly, see e.g.:
>
> https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?h=sunxi/dt-for-3.20&id=19a08b6b3f782f577b4b0fef9b6e60beba66c2f3
> 3) Write a proper commit message with a short description of the board, and
>    be sure to add a Signed-off-by: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> 4) Be sure to send the patch directly to Maxime Ripard, with
> devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>    in the Cc, you may Cc other people / lists too, but you must send it to
>    those 2 addresses.
>

My DT file is not complete. The nand part would probably be better in
a separate patch but I would like to have console working.

Thanks

Michal