Re: [PATCH_V2 04/34] MIPS: jz4740: probe CPU interrupt controller via DT

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 02/04/2015 06:21 PM, Zubair Lutfullah Kakakhel wrote:

> From: Paul Burton <paul.burton@imgtec.com>

> Use the generic irqchip_init function to probe irqchip drivers using DT,
> and add the appropriate node to the jz4740 devicetree in place of the
> call to mips_cpu_irq_init.

> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> ---
>   arch/mips/boot/dts/jz4740.dtsi | 7 +++++++
>   arch/mips/jz4740/irq.c         | 4 ++--
>   2 files changed, 9 insertions(+), 2 deletions(-)

> diff --git a/arch/mips/boot/dts/jz4740.dtsi b/arch/mips/boot/dts/jz4740.dtsi
> index c538691f..2d64765c 100644
> --- a/arch/mips/boot/dts/jz4740.dtsi
> +++ b/arch/mips/boot/dts/jz4740.dtsi
> @@ -2,4 +2,11 @@
>   	#address-cells = <1>;
>   	#size-cells = <1>;
>   	compatible = "ingenic,jz4740";
> +
> +	cpuintc: cpuintc@0 {

    Please name it "interrupt-controller". And why there's <unit-address> if 
there's no "reg" prop?

> +		#address-cells = <0>;
> +		#interrupt-cells = <1>;
> +		interrupt-controller;
> +		compatible = "mti,cpu-interrupt-controller";
> +	};
>   };
[...]

WBR, Sergei