* [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
@ 2015-02-08 15:48 Ivaylo Dimitrov
2015-02-08 18:37 ` Pali Rohár
2015-02-09 15:02 ` Nishanth Menon
0 siblings, 2 replies; 5+ messages in thread
From: Ivaylo Dimitrov @ 2015-02-08 15:48 UTC (permalink / raw)
To: tony; +Cc: pali.rohar, pavel, linux-omap, devicetree, Ivaylo Dimitrov
With legacy boot i2c buses on Nokia N900 are numbered i2c1, i2c2 and i2c3.
Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add i2c aliases") fixed the
numbering with DT boot, but introduced a regression on N900 - aliases
become i2c0, i2c1 and i2c2. Fix that by providing the correct aliases in
the board dts.
Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
---
arch/arm/boot/dts/omap3-n900.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index b550c41..68bf3cd 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -16,6 +16,13 @@
model = "Nokia N900";
compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3";
+ aliases {
+ i2c0;
+ i2c1 = &i2c1;
+ i2c2 = &i2c2;
+ i2c3 = &i2c3;
+ };
+
cpus {
cpu@0 {
cpu0-supply = <&vcc>;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
2015-02-08 15:48 [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering Ivaylo Dimitrov
@ 2015-02-08 18:37 ` Pali Rohár
2015-02-09 15:02 ` Nishanth Menon
1 sibling, 0 replies; 5+ messages in thread
From: Pali Rohár @ 2015-02-08 18:37 UTC (permalink / raw)
To: Ivaylo Dimitrov; +Cc: tony, pavel, linux-omap, devicetree
[-- Attachment #1: Type: Text/Plain, Size: 649 bytes --]
On Sunday 08 February 2015 16:48:56 Ivaylo Dimitrov wrote:
> With legacy boot i2c buses on Nokia N900 are numbered i2c1,
> i2c2 and i2c3. Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add
> i2c aliases") fixed the numbering with DT boot, but
> introduced a regression on N900 - aliases become i2c0, i2c1
> and i2c2. Fix that by providing the correct aliases in the
> board dts.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
> arch/arm/boot/dts/omap3-n900.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
Works fine,
Tested-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
2015-02-08 15:48 [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering Ivaylo Dimitrov
2015-02-08 18:37 ` Pali Rohár
@ 2015-02-09 15:02 ` Nishanth Menon
2015-02-09 16:03 ` Ivaylo Dimitrov
1 sibling, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2015-02-09 15:02 UTC (permalink / raw)
To: Ivaylo Dimitrov; +Cc: tony, pali.rohar, pavel, linux-omap, devicetree
On 17:48-20150208, Ivaylo Dimitrov wrote:
> With legacy boot i2c buses on Nokia N900 are numbered i2c1, i2c2 and i2c3.
> Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add i2c aliases") fixed the
> numbering with DT boot, but introduced a regression on N900 - aliases
> become i2c0, i2c1 and i2c2. Fix that by providing the correct aliases in
> the board dts.
>
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
I suppose this is due to some legacy userspace breakage?
if yes, we do not intend to break userspace :), So:
Acked-by: Nishanth Menon <nm@ti.com>
> arch/arm/boot/dts/omap3-n900.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index b550c41..68bf3cd 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -16,6 +16,13 @@
> model = "Nokia N900";
> compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3";
>
> + aliases {
> + i2c0;
> + i2c1 = &i2c1;
> + i2c2 = &i2c2;
> + i2c3 = &i2c3;
> + };
> +
> cpus {
> cpu@0 {
> cpu0-supply = <&vcc>;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
2015-02-09 15:02 ` Nishanth Menon
@ 2015-02-09 16:03 ` Ivaylo Dimitrov
2015-02-24 18:02 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Ivaylo Dimitrov @ 2015-02-09 16:03 UTC (permalink / raw)
To: Nishanth Menon; +Cc: tony, pali.rohar, pavel, linux-omap, devicetree
On 9.02.2015 17:02, Nishanth Menon wrote:
> On 17:48-20150208, Ivaylo Dimitrov wrote:
>> With legacy boot i2c buses on Nokia N900 are numbered i2c1, i2c2 and i2c3.
>> Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add i2c aliases") fixed the
>> numbering with DT boot, but introduced a regression on N900 - aliases
>> become i2c0, i2c1 and i2c2. Fix that by providing the correct aliases in
>> the board dts.
>>
>> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
>> ---
> I suppose this is due to some legacy userspace breakage?
> if yes, we do not intend to break userspace :), So:
Yes, legacy userspace breakage :)
Regards,
Ivo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
2015-02-09 16:03 ` Ivaylo Dimitrov
@ 2015-02-24 18:02 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2015-02-24 18:02 UTC (permalink / raw)
To: Ivaylo Dimitrov; +Cc: Nishanth Menon, pali.rohar, pavel, linux-omap, devicetree
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [150209 08:07]:
>
>
> On 9.02.2015 17:02, Nishanth Menon wrote:
> >On 17:48-20150208, Ivaylo Dimitrov wrote:
> >>With legacy boot i2c buses on Nokia N900 are numbered i2c1, i2c2 and i2c3.
> >>Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add i2c aliases") fixed the
> >>numbering with DT boot, but introduced a regression on N900 - aliases
> >>become i2c0, i2c1 and i2c2. Fix that by providing the correct aliases in
> >>the board dts.
> >>
> >>Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> >>---
> >I suppose this is due to some legacy userspace breakage?
> >if yes, we do not intend to break userspace :), So:
>
> Yes, legacy userspace breakage :)
Applying into omap-for-v4.0/fixes thanks,
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-24 18:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-08 15:48 [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering Ivaylo Dimitrov
2015-02-08 18:37 ` Pali Rohár
2015-02-09 15:02 ` Nishanth Menon
2015-02-09 16:03 ` Ivaylo Dimitrov
2015-02-24 18:02 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).