From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 2/4 V2] dt-bindings: Add root properties for Raspberry Pi Date: Mon, 09 Feb 2015 11:06:28 -0700 Message-ID: <54D8F724.4080609@wwwdotorg.org> References: <1421665231-28221-1-git-send-email-stefan.wahren@i2se.com> <54BD3B49.4050203@wwwdotorg.org> <1722146904.386302.1421694080817.JavaMail.open-xchange@oxbaltgw08.schlund.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1722146904.386302.1421694080817.JavaMail.open-xchange@oxbaltgw08.schlund.de> Sender: linux-kernel-owner@vger.kernel.org To: Stefan Wahren Cc: linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, devicetree@vger.kernel.org, lee@kernel.org, pawel.moll@arm.com, linux@arm.linux.org.uk, robh+dt@kernel.org, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, mark.rutland@arm.com List-Id: devicetree@vger.kernel.org On 01/19/2015 12:01 PM, Stefan Wahren wrote: > Hi Stephen, > >> Stephen Warren hat am 19. Januar 2015 um 18:13 >> geschrieben: >> >> >> On 01/19/2015 04:00 AM, Stefan Wahren wrote: >>> This patch adds root compatible properties for the following boards: >>> - Raspberry Pi Model A >>> - Raspberry Pi Model A+ >>> - Raspberry Pi Model B >>> - Raspberry Pi Model B (no P5) >>> - Raspberry Pi Model B rev2 >>> - Raspberry Pi Model B+ >>> - Raspberry Pi Compute Module >> >> Acked-by: Stephen Warren >> >> This seems sane to me. One thing I should have asked: What compatible >> values does the RPi Foundation's downstream for all these cases? > > good point. Unfortunately my patches to linux-rpi-kernel are held back because > of too many recipients, so it's possible that someone complain later. > > I have looked at chapter 3.1 in [1], but didn't find the any other variants than > B and B+: > > Here, the presence or absence of the "-plus" is the significant thing, not the > "b" -- Model A's and A+'s will > use the "b" and "b-plus" variants, respectively. > > Also in the newest branch [2]: > > bcm2835-rpi-b.dts -> model = Raspberry Pi Model B > bcm2708-rpi-b.dts -> model = Raspberry Pi Model B > bcm2708-rpi-b-plus.dts -> model = Raspberry Pi Model B+ > > Sorry, i don't have any experience with the downstream kernel. So please correct > me if looked at the wrong places. > > [1] - > https://github.com/raspberrypi/documentation/blob/master/configuration/device-tree.md > [2] - https://github.com/raspberrypi/linux/tree/rpi-3.18.y/ This all matches what I found. I think differentiating between A/B and A+/B+ makes sense, so the compatible values in your patch should be fine; I'll reply to v2 in just a minute.