From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver Date: Mon, 16 Feb 2015 22:48:01 +0900 Message-ID: <54E1F511.1090604@samsung.com> References: <1423025771-4139-1-git-send-email-jaewon02.kim@samsung.com> <1423025771-4139-2-git-send-email-jaewon02.kim@samsung.com> <54D20A32.1020604@samsung.com> <20150216134206.GH14545@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150216134206.GH14545@x1> Sender: linux-pm-owner@vger.kernel.org To: Lee Jones Cc: Jaewon Kim , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Inki Dae , SangBae Lee , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Sebastian Reichel , Mark Brown , Beomho Seo List-Id: devicetree@vger.kernel.org On 02/16/2015 10:42 PM, Lee Jones wrote: > On Wed, 04 Feb 2015, Chanwoo Choi wrote: >> On 02/04/2015 01:56 PM, Jaewon Kim wrote: >>> This patch adds MAX77843 core/irq driver to support PMIC, >>> MUIC(Micro USB Interface Controller), Charger, Fuel Gauge, >>> LED and Haptic device. >>> >>> Cc: Lee Jones >>> Signed-off-by: Jaewon Kim >>> Signed-off-by: Beomho Seo >>> --- >>> drivers/mfd/Kconfig | 14 ++ >>> drivers/mfd/Makefile | 1 + >>> drivers/mfd/max77843.c | 245 +++++++++++++++++++ >>> include/linux/mfd/max77843-private.h | 441 ++++++++++++++++++++++++++++++++++ >>> 4 files changed, 701 insertions(+) >>> create mode 100644 drivers/mfd/max77843.c >>> create mode 100644 include/linux/mfd/max77843-private.h > > > >> Looks good to me. >> >> Reviewed-by: Chanwoo Choi > > Chanwoo, > > If you're not going to make any comments, either put the Reviewed-by > at the top, or better still, snip out all of the bumph in the middle. > OK, I'll do according your comment. Thanks, Chanwoo Choi