From: zhangfei <zhangfei.gao@linaro.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
balbi@ti.com, mark.rutland@arm.com,
Peter Chen <peter.chen@freescale.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"dan . zhao" <dan.zhao@hisilicon.com>,
Wangbinghui <wangbinghui@hisilicon.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v4 4/4] phy: add phy-hi6220-usb
Date: Wed, 18 Feb 2015 13:44:21 +0800 [thread overview]
Message-ID: <54E426B5.4070206@linaro.org> (raw)
In-Reply-To: <54E4249C.9050404@ti.com>
Hi, Kishon
On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote:
>> Add usb phy controller for hi6220 platform
>>
>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>> ---
>> drivers/phy/Kconfig | 9 ++
>> drivers/phy/Makefile | 1 +
>> drivers/phy/phy-hi6220-usb.c | 306
>> +++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 316 insertions(+)
>> create mode 100644 drivers/phy/phy-hi6220-usb.c
>
> why is this driver in drivers/phy when it doesn't use the generic PHY
> framework at all?
>
Balbi recommended "new drivers only on drivers/phy/", including usb phy.
So Move drivers/usb/phy/phy-hi6220-usb.c to
drivers/phy/phy-hi6220-usb.c, required by Balbi.
Thanks
next prev parent reply other threads:[~2015-02-18 5:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 7:37 [PATCH v4 0/4] add usb support for hi6220 Zhangfei Gao
2015-02-12 7:37 ` [PATCH v4 1/4] Documentation: dt-bindings: add dt binding info for hi6220 dwc2 Zhangfei Gao
2015-02-12 7:37 ` [PATCH v4 2/4] Documentation: dt-bindings: add dt binding info for hi6220 Zhangfei Gao
2015-02-12 7:37 ` [PATCH v4 3/4] usb: dwc2: platform: add hi6220 support Zhangfei Gao
2015-02-12 7:37 ` [PATCH v4 4/4] phy: add phy-hi6220-usb Zhangfei Gao
2015-02-18 5:35 ` Kishon Vijay Abraham I
2015-02-18 5:44 ` zhangfei [this message]
2015-02-18 14:35 ` Felipe Balbi
2015-02-20 3:07 ` zhangfei
[not found] ` <54E6A4E9.4030401-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-02-20 4:38 ` Felipe Balbi
[not found] ` <20150220043805.GA22128-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-02-20 10:27 ` zhangfei
2015-02-20 14:41 ` Felipe Balbi
[not found] ` <20150220144119.GB1707-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-02-20 15:44 ` zhangfei
2015-02-20 16:06 ` Felipe Balbi
2015-02-21 15:03 ` zhangfei
2015-02-21 16:21 ` Felipe Balbi
2015-02-22 3:10 ` zhangfei
[not found] ` <54E948AC.2010609-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-02-23 15:36 ` Felipe Balbi
2015-02-25 13:28 ` zhangfei
2015-02-25 16:32 ` Felipe Balbi
2015-02-24 10:13 ` Roger Quadros
[not found] ` <54EC4ECA.2090300-l0cyMroinI0@public.gmane.org>
2015-02-26 8:48 ` zhangfei
2015-02-26 9:36 ` Roger Quadros
2015-02-27 2:07 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E426B5.4070206@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=balbi@ti.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peter.chen@freescale.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).