devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
@ 2015-02-18 16:17 Andreas Färber
       [not found] ` <1424276245-7028-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2015-02-18 16:17 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: linux-arm-kernel, devicetree, Vincent Palatin, Doug Anderson,
	Javier Martinez Canillas, Tomasz Figa, Andreas Färber,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Kukjin Kim, open list

Configure the pins in external interrupt mode, as done for Snow in
e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
exynos5250-snow").

Reported-by: Kukjin Kim <kgene@kernel.org>
Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 arch/arm/boot/dts/exynos5250-spring.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts
index c41600e587e0..d075a68ac078 100644
--- a/arch/arm/boot/dts/exynos5250-spring.dts
+++ b/arch/arm/boot/dts/exynos5250-spring.dts
@@ -482,7 +482,7 @@
 
 	power_key_irq: power-key-irq {
 		samsung,pins = "gpx1-3";
-		samsung,pin-function = <0>;
+		samsung,pin-function = <0xf>;
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
@@ -510,7 +510,7 @@
 
 	lid_irq: lid-irq {
 		samsung,pins = "gpx3-5";
-		samsung,pin-function = <0>;
+		samsung,pin-function = <0xf>;
 		samsung,pin-pud = <0>;
 		samsung,pin-drv = <0>;
 	};
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
       [not found] ` <1424276245-7028-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
@ 2015-02-19 11:49   ` Javier Martinez Canillas
  2015-03-16 14:54     ` Andreas Färber
  0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-02-19 11:49 UTC (permalink / raw)
  To: Andreas Färber, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA, Vincent Palatin, Doug Anderson,
	Tomasz Figa, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, Kukjin Kim, open list

Hello Andreas,

On 02/18/2015 05:17 PM, Andreas Färber wrote:
> Configure the pins in external interrupt mode, as done for Snow in
> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
> exynos5250-snow").
> 
> Reported-by: Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Suggested-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8p/WX4DV1PbvA@public.gmane.orguk>
> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
> ---

Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
  2015-02-19 11:49   ` Javier Martinez Canillas
@ 2015-03-16 14:54     ` Andreas Färber
  2015-03-17 16:33       ` Kukjin Kim
  0 siblings, 1 reply; 4+ messages in thread
From: Andreas Färber @ 2015-03-16 14:54 UTC (permalink / raw)
  To: linux-samsung-soc, Kukjin Kim
  Cc: Javier Martinez Canillas, linux-arm-kernel, devicetree,
	Vincent Palatin, Doug Anderson, Tomasz Figa, Rob Herring,
	Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
	LKML

Kukjin,

Am 19.02.2015 um 12:49 schrieb Javier Martinez Canillas:
> Hello Andreas,
> 
> On 02/18/2015 05:17 PM, Andreas Färber wrote:
>> Configure the pins in external interrupt mode, as done for Snow in
>> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
>> exynos5250-snow").
>>
>> Reported-by: Kukjin Kim <kgene@kernel.org>
>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
> 
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Ping?

Regards,
Andreas

> 
> Best regards,
> Javier

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring
  2015-03-16 14:54     ` Andreas Färber
@ 2015-03-17 16:33       ` Kukjin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2015-03-17 16:33 UTC (permalink / raw)
  To: Andreas Färber
  Cc: linux-samsung-soc, Kukjin Kim, Javier Martinez Canillas,
	linux-arm-kernel, devicetree, Vincent Palatin, Doug Anderson,
	Tomasz Figa, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, LKML

On 03/16/15 23:54, Andreas Färber wrote:
> Kukjin,
> 
> Am 19.02.2015 um 12:49 schrieb Javier Martinez Canillas:
>> Hello Andreas,
>>
>> On 02/18/2015 05:17 PM, Andreas Färber wrote:
>>> Configure the pins in external interrupt mode, as done for Snow in
>>> e5e5c6d14e39 ("ARM: dts: Add power and lid GPIO keys pinctrl for
>>> exynos5250-snow").
>>>
>>> Reported-by: Kukjin Kim <kgene@kernel.org>
>>> Suggested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> Fixes: 53dd4138bb0a ("ARM: dts: Add exynos5250-spring device tree")
>>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>>> ---
>>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 
> Ping?
> 
Thanks, applied.

- Kukjin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-03-17 16:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-18 16:17 [PATCH] ARM: dts: Update lid and power pin-functions for exynos5250-spring Andreas Färber
     [not found] ` <1424276245-7028-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2015-02-19 11:49   ` Javier Martinez Canillas
2015-03-16 14:54     ` Andreas Färber
2015-03-17 16:33       ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).