From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-sh@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF DT support
Date: Thu, 19 Feb 2015 22:13:42 +0300 [thread overview]
Message-ID: <54E635E6.1010409@cogentembedded.com> (raw)
In-Reply-To: <20150219175458.GA18262@verge.net.au>
On 02/19/2015 08:55 PM, Simon Horman wrote:
>>>> Define the generic R8A7794 part of the MMCIF0 device node.
>>>> Based on the orginal patch by Shinobu Uehara <shinobu.uehara.xc@renesas.com>.
>>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>>> ---
>>>> arch/arm/boot/dts/r8a7794.dtsi | 11 +++++++++++
>>>> 1 file changed, 11 insertions(+)
>>>> Index: renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> ===================================================================
>>>> --- renesas.orig/arch/arm/boot/dts/r8a7794.dtsi
>>>> +++ renesas/arch/arm/boot/dts/r8a7794.dtsi
>>>> @@ -346,6 +346,17 @@
>>>> status = "disabled";
>>>> };
>>>>
>>>> + mmcif0: mmc@ee200000 {
>>>> + compatible = "renesas,mmcif-r8a7794", "renesas,sh-mmcif";
>>> Please submit a patch to add "renesas,mmcif-r8a7794" to
>>> Documentation/devicetree/bindings/mmc/renesas,mmcif.txt.
>>> I looked and I couldn't find such a change in-tree or in-flight.
>> That file doesn't match the reality at all. It says:
>> <<
>> - compatible: must contain one of the following
>> - "renesas,mmcif-r8a7740" for the MMCIF found in r8a7740 SoCs
>> - "renesas,mmcif-r8a7790" for the MMCIF found in r8a7790 SoCs
>> - "renesas,mmcif-r8a7791" for the MMCIF found in r8a7791 SoCs
>> - "renesas,sh-mmcif" for the generic MMCIF
>>>>
>> while in reality, the driver only matches on the latter string and doesn't
>> care for the SoC specific strings.
> By documenting the binding in that file it exists and may be used in DT
> nodes. It may or may not be used by the driver now or in the future.
What's the use of binding the driver doesn't understand?
> For better or worse this one way that bindings may be handled.
> Strictly speaking it shouldn't be used in DT before it exists,
> even only in the documentation. But in this case its just a minor
> update to an existing scheme so it seems unlikely to be rejected.
I don't think the minor update will be rejected, I just wanted to say that
the binding should be edited to better reflect the reality as well. And it
falls on my shoulders, unfortunately. :-)
WBR, Sergei
next prev parent reply other threads:[~2015-02-19 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 22:57 [PATCH 0/2 resend] Add R8A7794/SILK board eMMC DT support Sergei Shtylyov
2015-02-16 22:59 ` [PATCH 1/2] ARM: shmobile: r8a7794: add MMCIF " Sergei Shtylyov
2015-02-19 16:10 ` Simon Horman
2015-02-19 17:02 ` Sergei Shtylyov
2015-02-19 17:55 ` Simon Horman
2015-02-19 19:13 ` Sergei Shtylyov [this message]
2015-02-16 23:00 ` [PATCH 2/2] ARM: shmobile: silk: add eMMC " Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E635E6.1010409@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=horms@verge.net.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).