From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: Re: [PATCH] ARM: sun6i: dt: Add new Mele I7 device Date: Tue, 03 Mar 2015 08:55:36 +0100 Message-ID: <54F568F8.1040104@redhat.com> References: <1425131285-8640-1-git-send-email-codekipper@gmail.com> <20150303071635.GC4713@lukather> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: <20150303071635.GC4713@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 03-03-15 08:16, Maxime Ripard wrote: > On Sat, Feb 28, 2015 at 02:48:05PM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: >> From: Marcus Cooper >> >> The Mele I7 is a Allwinner A31 based Android TV box, with 1G RAM, >> 8GB NAND flash, a RTL8188etv wifi chip, 3 USB Host ports using >> USB-A receptacles, a micro USB-B receptacle for USB OTG, HDMI out, >> a TRS connector for A/V, SPDIF and IrDA. >> >> This patch adds basic support for the device, more information can >> be found here (http://linux-sunxi.org/Mele_I7). >> >> Signed-off-by: Marcus Cooper >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/sun6i-a31-i7.dts | 150 +++++++++++++++++++++++++++++++++++++ >> 2 files changed, 151 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun6i-a31-i7.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index eae7706..8d9d5ea 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -532,6 +532,7 @@ dtb-$(CONFIG_MACH_SUN6I) += \ >> sun6i-a31-app4-evb1.dtb \ >> sun6i-a31-colombus.dtb \ >> sun6i-a31-hummingbird.dtb \ >> + sun6i-a31-i7.dtb \ >> sun6i-a31-m9.dtb \ >> sun6i-a31s-cs908.dtb >> dtb-$(CONFIG_MACH_SUN7I) += \ >> diff --git a/arch/arm/boot/dts/sun6i-a31-i7.dts b/arch/arm/boot/dts/sun6i-a31-i7.dts >> new file mode 100644 >> index 0000000..43fdcd5 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun6i-a31-i7.dts >> @@ -0,0 +1,150 @@ >> +/* >> + * Copyright 2015 Marcus Cooper >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public >> + * License along with this file; if not, write to the Free >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, >> + * MA 02110-1301 USA >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/dts-v1/; >> +#include "sun6i-a31.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include >> +#include >> + >> +/ { >> + model = "Mele I7 Quad top set box"; >> + compatible = "mele,i7", "allwinner,sun6i-a31"; >> + >> + chosen { >> + bootargs = "earlyprintk console=ttyS0,115200"; > > Using earlyprintk by default is a bad idea if the kernel is configured > with DEBUG_LL support for another SoC. While on this subject, u-boot now sets the chosen/stdout-path property up by default, which means that the kernel will do the right thing by default. So we we really do not need any bootargs= in our dts files. Currently we've a random mix where we do have bootargs in some, but not in most sunxi dts files. I believe we should simply remove it everywhere... Regards, Hans