Re: [PATCH 2/2] ASoC: simple-card: Add support for samplerate and samplewidth constraints

[Jyri Sarha <jsarha@ti.com>]

On 03/02/2015 09:58 PM, Lars-Peter Clausen wrote:
> On 03/02/2015 03:14 PM, Jyri Sarha wrote:
>> Add DT properties to dailink for setting samplerate and samplewidth
>> constraints. The DT binding document has been updated.
>
> Can you include a description why this is needed and how and when it is
> supposed to be used?

Would this addition do:
------------------------------------------------------------
These constraints help to disable the sample-format and sample-rate
combinations that do not properly work on a specific HW.
------------------------------------------------------------

The reason why we need these is coming from limitations in McASP clock 
generation. With a simple divider one can only produce certain 
bit-clocks. With those bit-clocks we can only play/capture some 
sample-rate and sample-width combinations accurately.

The McASP driver could try to set the constraints automatically. 
However, since the constraint code can not select sample-width and 
sample-rate combinations there is a compromise to be made between them. 
Making such compromises automatically does not usually work that well.

In our case these properties could of course be added to McASP driver, 
but then again I would expect that there is a wider need for this kind 
of functionality. And it may not always be clear if either end of the 
link alone is responsible for less than perfect operation.

Best regards,
Jyri