From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 07/10] usb: Make sure that DWC2 initializes after the power channel mailbox driver. Date: Tue, 03 Mar 2015 20:17:24 -0700 Message-ID: <54F67944.1030501@wwwdotorg.org> References: <1425329684-23968-1-git-send-email-eric@anholt.net> <1425329684-23968-8-git-send-email-eric@anholt.net> <20150303083250.GG6976@x1> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150303083250.GG6976@x1> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones , Eric Anholt Cc: linux-arm-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jassi Brar , Craig McGeachie , Lubomir Rintel , John Youn List-Id: devicetree@vger.kernel.org On 03/03/2015 01:32 AM, Lee Jones wrote: > On Mon, 02 Mar 2015, Eric Anholt wrote: >> This gets USB working on the Raspberry Pi without relying on U-Boot to >> send the power message for us. Without it, you would get warnings >> about fifo sizes and "dwc2_core_reset() HANG! Soft Reset >> GRSTCTL=80000001" leading to a failed probe. >> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c >> +bool bcm2835_usb_power_enabled(void) >> +{ >> +#ifdef CONFIG_BCM2835_MBOX > > Please don't put #ifdeffery in *.c files. If you have to match on > CONFIG_* options, please do so using inlines in a header file > somewhere. I haven't heard of that restriction before. I'm sure there are many ifdefs in C files in the kernel. What benefit does moving the ifdefs into headers have? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html