From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 3/5] dt-bindings: mediatek: Add smi dts binding Date: Fri, 06 Mar 2015 17:48:53 +0300 Message-ID: <54F9BE55.90601@cogentembedded.com> References: <1425638900-24989-1-git-send-email-yong.wu@mediatek.com> <1425638900-24989-4-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1425638900-24989-4-git-send-email-yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Rob Herring , Joerg Roedel , Matthias Brugger Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Catalin Marinas , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tomasz Figa , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Daniel Kurtz , Sasha Hauer , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lucas Stach List-Id: devicetree@vger.kernel.org Hello. On 3/6/2015 1:48 PM, yong.wu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > From: Yong Wu > This patch add smi binding document. > Signed-off-by: Yong Wu > --- > .../devicetree/bindings/soc/mediatek/mediatek,smi.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > diff --git a/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > new file mode 100644 > index 0000000..0fc9d1a > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/mediatek/mediatek,smi.txt > @@ -0,0 +1,17 @@ > +SMI hardware block diagram please help check > + > +Required properties: > +- compatible : must be "mediatek,mediatek,mt8173-smi-larb" One "mediatek," is enough. :-) > +- reg : the register of each local arbiter > +- clocks : the clocks of each local arbiter > +- clock-name: larb_sub*(3 clockes at most) clock-names. > + > +Example: > + larb1:larb@16010000 { > + compatible = "mediatek,mt8173-smi-larb"; > + reg = <0 0x16010000 0 0x1000>; > + clocks = <&mmsys MM_SMI_COMMON>, > + <&vdecsys VDEC_CKEN>, Please align with the < above. > + <&vdecsys VDEC_LARB_CKEN>; Use tabs instead of spaces, please. > + clock-names = "larb_sub0", "larb_sub1", "larb_sub2"; > + }; WBR, Sergei