From: "long.wanglong" <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Gaurav Minocha
<gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH] Documentation: update the of_selftest.txt
Date: Mon, 9 Mar 2015 10:25:23 +0800 [thread overview]
Message-ID: <54FD0493.3000805@huawei.com> (raw)
In-Reply-To: <CAL_JsqKrYXnnPdL+wvkCKZr-q6z-2Wa+PDEaz7ixxvtDNAE3jw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 2015/3/6 22:40, Rob Herring wrote:
> On Mon, Mar 2, 2015 at 9:56 PM, Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
>> Since the directory "drivers/of/testcase-data" is renamed
>> to "drivers/of/unittest-data". so we should update the path
>> in the of_selftest.txt.
>>
>> When the kernel is build with OF_SELFTEST enabled, the output
>
> s/build/built/
>
> s/SELF/UNIT/
sorry for the mistakes.
>
>> dtb is testcases.dtb instead of testcase.dtb, also update it
>> (s/testcase/testcases/).
>>
>> Signed-off-by: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> ---
>> Documentation/devicetree/of_selftest.txt | 22 +++++++++++-----------
>
> Please rename to of_unittest.txt as well and rename occurrences of
> selftest to unittest.
>
> Rob
OK
>
>> 1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/Documentation/devicetree/of_selftest.txt b/Documentation/devicetree/of_selftest.txt
>> index 57a808b..ffce144 100644
>> --- a/Documentation/devicetree/of_selftest.txt
>> +++ b/Documentation/devicetree/of_selftest.txt
>> @@ -22,31 +22,31 @@ most of the device drivers in various use cases.
>>
>> 2. Test-data
>>
>> -The Device Tree Source file (drivers/of/testcase-data/testcases.dts) contains
>> +The Device Tree Source file (drivers/of/unittest-data/testcases.dts) contains
>> the test data required for executing the unit tests automated in
>> -drivers/of/selftests.c. Currently, following Device Tree Source Include files
>> -(.dtsi) are included in testcase.dts:
>> +drivers/of/unittest.c. Currently, following Device Tree Source Include files
>> +(.dtsi) are included in testcases.dts:
>>
>> -drivers/of/testcase-data/tests-interrupts.dtsi
>> -drivers/of/testcase-data/tests-platform.dtsi
>> -drivers/of/testcase-data/tests-phandle.dtsi
>> -drivers/of/testcase-data/tests-match.dtsi
>> +drivers/of/unittest-data/tests-interrupts.dtsi
>> +drivers/of/unittest-data/tests-platform.dtsi
>> +drivers/of/unittest-data/tests-phandle.dtsi
>> +drivers/of/unittest-data/tests-match.dtsi
>>
>> When the kernel is build with OF_SELFTEST enabled, then the following make rule
>>
>> $(obj)/%.dtb: $(src)/%.dts FORCE
>> $(call if_changed_dep, dtc)
>>
>> -is used to compile the DT source file (testcase.dts) into a binary blob
>> -(testcase.dtb), also referred as flattened DT.
>> +is used to compile the DT source file (testcases.dts) into a binary blob
>> +(testcases.dtb), also referred as flattened DT.
>>
>> After that, using the following rule the binary blob above is wrapped as an
>> -assembly file (testcase.dtb.S).
>> +assembly file (testcases.dtb.S).
>>
>> $(obj)/%.dtb.S: $(obj)/%.dtb
>> $(call cmd, dt_S_dtb)
>>
>> -The assembly file is compiled into an object file (testcase.dtb.o), and is
>> +The assembly file is compiled into an object file (testcases.dtb.o), and is
>> linked into the kernel image.
>>
>>
>> --
>> 1.8.3.4
>>
>
> .
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-03-09 2:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 3:56 [PATCH] Documentation: update the of_selftest.txt Wang Long
[not found] ` <1425355008-56957-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-06 14:40 ` Rob Herring
[not found] ` <CAL_JsqKrYXnnPdL+wvkCKZr-q6z-2Wa+PDEaz7ixxvtDNAE3jw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-09 2:25 ` long.wanglong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FD0493.3000805@huawei.com \
--to=long.wanglong-hv44wf8li93qt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gaurav.minocha.os-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=peifeiyue-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).