From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thor Thayer Subject: Re: [RFC/PATCHv2 2/3] dt-binding: spi: spi-dw: Select 16b or 32b access for Designware SPI Date: Mon, 9 Mar 2015 13:11:28 -0500 Message-ID: <54FDE250.3050705@opensource.altera.com> References: <1425685594-26595-1-git-send-email-tthayer@opensource.altera.com> <1425685594-26595-3-git-send-email-tthayer@opensource.altera.com> Reply-To: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Andy Shevchenko Cc: Mark Brown , Grant Likely , Jiri Kosina , Pawel Moll , Rob Herring , Mark Rutland , ijc+devicetree@hellion.org.uk, dinguyen@opensource.altera.com, Linux Documentation List , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, tthayer.linux@gmail.com, Axel Lin , baruch@tkos.co.il, Andy Shevchenko , Jingoo Han , Kumar Gala List-Id: devicetree@vger.kernel.org On 03/07/2015 01:58 PM, Andy Shevchenko wrote: > On Sat, Mar 7, 2015 at 1:46 AM, wrot= e: >> From: Thor Thayer >> >> Altera's Arria10 architecture requires a 32bit write accesses for >> APB peripherals. The current spi-dw driver uses 16bit accesses in >> some locations. This patch updated the bindings with an optional >> field in the devicetree to select 32bit accesses. >> > > One comment below. > >> Signed-off-by: Thor Thayer >> --- >> Documentation/devicetree/bindings/spi/spi-dw.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/spi/spi-dw.txt b/Docu= mentation/devicetree/bindings/spi/spi-dw.txt >> index 7b63ed6..034dbdd 100644 >> --- a/Documentation/devicetree/bindings/spi/spi-dw.txt >> +++ b/Documentation/devicetree/bindings/spi/spi-dw.txt >> @@ -11,6 +11,7 @@ Required properties: >> >> Optional properties: >> - cs-gpios: see spi-bus.txt >> +- 32bit_access : use 32 bit register accesses >> > > The most big issue for my opinion with DT is an absence of the > standard for naming properties. > > So, why underscore? May be it's a time to append a generic descriptio= n > of this field to Documentation/devicetree/=E2=80=A6 > Hi Andy, I'm use the underscore to make it easier to read but I'm open to=20 suggestions. I stay away from dashes because these variable names are problematic to= =20 parse in languages like Python which may be used as an external tool. I don't mind making it just 32bit if that is preferable or implementing= =20 a better field name. Thanks for reviewing