From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 09/15] ARM: dts: sun4i: Add USB Dual Role Controller Date: Tue, 10 Mar 2015 10:10:24 +0100 Message-ID: <54FEB500.8050409@redhat.com> References: <1425933628-9672-1-git-send-email-hdegoede@redhat.com> <1425933628-9672-10-git-send-email-hdegoede@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Julian Calaby , linux-sunxi Cc: Felipe Balbi , Kishon Vijay Abraham I , Maxime Ripard , Chen-Yu Tsai , Roman Byshko , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Mailing List, Arm" , devicetree List-Id: devicetree@vger.kernel.org Hi, On 10-03-15 00:31, Julian Calaby wrote: > Hi Hans, > > On Tue, Mar 10, 2015 at 7:40 AM, Hans de Goede wrote: >> Add a node for the otg/drc usb controller to sun4i-a10.dtsi. >> >> Signed-off-by: Hans de Goede >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 12 ++++++++++++ >> drivers/usb/musb/Kconfig | 1 + >> 2 files changed, 13 insertions(+) >> >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig >> index 8180a3a..fab8e9a 100644 >> --- a/drivers/usb/musb/Kconfig >> +++ b/drivers/usb/musb/Kconfig >> @@ -65,6 +65,7 @@ comment "Platform Glue Layer" >> config USB_MUSB_SUNXI >> tristate "Allwinner (sunxi)" >> depends on ARCH_SUNXI >> + depends on NOP_USB_XCEIV > > Shouldn't this be in a different patch? Yes, this was a later fixup commit which got squashed into the wrong patch, thanks for catching this. This has been fixed in my personal tree, and will be in v2 of this set: https://github.com/jwrdegoede/linux-sunxi/commits/sunxi-wip Regards, Hans