From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH 12/15] ARM: dts: sun4i: Enable USB DRC on
 Chuwi V7 CW0825
Date: Tue, 10 Mar 2015 16:23:09 +0100
Message-ID: <54FF0C5D.3090706@redhat.com>
References: <1425933628-9672-1-git-send-email-hdegoede@redhat.com> <1425933628-9672-13-git-send-email-hdegoede@redhat.com> <20150310150741.GW5085@lukather>
Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Return-path: <linux-sunxi+bncBDRZXY4CYYORB2MY7STQKGQEJPKFRSA-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
In-Reply-To: <20150310150741.GW5085@lukather>
List-Post: <http://groups.google.com/group/linux-sunxi/post>, <mailto:linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
List-Help: <http://groups.google.com/support/>, <mailto:linux-sunxi+help-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
List-Archive: <http://groups.google.com/group/linux-sunxi
Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
List-Subscribe: <http://groups.google.com/group/linux-sunxi/subscribe>, <mailto:linux-sunxi+subscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
List-Unsubscribe: <mailto:googlegroups-manage+1076902468213+unsubscribe-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
 <http://groups.google.com/group/linux-sunxi/subscribe>
To: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>, Kishon Vijay Abraham I <kishon-l0cyMroinI0@public.gmane.org>, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>, Roman Byshko <rbyshko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
List-Id: devicetree@vger.kernel.org

Hi,

On 03/10/2015 04:07 PM, Maxime Ripard wrote:
> Hi Hans,
>
> On Mon, Mar 09, 2015 at 09:40:25PM +0100, Hans de Goede wrote:
>> Enable the otg/drc usb controller on the Chuwi V7 CW0825 tablet.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts | 31 +++++++++++++++++++++++++
>>   1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts b/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
>> index 97fca89..034396c 100644
>> --- a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
>> +++ b/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
>> @@ -111,6 +111,26 @@
>>   	status = "okay";
>>   };
>>
>> +&pio {
>> +	usb0_id_detect_pin: usb0_id_detect_pin@0 {
>> +		allwinner,pins = "PH4";
>> +		allwinner,function = "gpio_in";
>> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> +		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
>> +	};
>> +
>> +	usb0_vbus_detect_pin: usb0_vbus_detect_pin@0 {
>> +		allwinner,pins = "PH5";
>> +		allwinner,function = "gpio_in";
>> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
>> +		allwinner,pull = <SUN4I_PINCTRL_PULL_DOWN>;
>> +	};
>> +};
>> +
>> +&reg_usb0_vbus {
>> +	status = "okay";
>> +};
>> +
>>   &reg_usb2_vbus {
>>   	status = "okay";
>>   };
>> @@ -121,7 +141,18 @@
>>   	status = "okay";
>>   };
>>
>> +&usb_otg {
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&usb0_id_detect_pin
>> +		     &usb0_vbus_detect_pin>;
>> +	id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
>> +	vbus_det-gpio = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
>> +	dr_mode = "otg";
>
> Is there a reason to not put that in the DTSI?

This is not in the dtsi because it is board specific.

> All the users seem to be wiring it as OTG.

Sofar I've only enabled the otg on a handful of boards,
the otg on the Mele-M9 for example is connected to a usb->sata
bridge and as such should be brought up in host only mode.

And on the wobo-i5 (which I still need to create a dts file for)
the otg is connected to an usb wifi module.

Regards,

Hans