From: "long.wanglong" <long.wanglong@huawei.com>
To: Gaurav Minocha <gaurav.minocha.os@gmail.com>
Cc: Rob Herring <robherring2@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Grant Likely <grant.likely@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Kumar Gala <galak@codeaurora.org>,
peifeiyue@huawei.com
Subject: Re: [PATCH v2 1/2] Documentation: update the of_selftest.txt
Date: Wed, 11 Mar 2015 11:07:26 +0800 [thread overview]
Message-ID: <54FFB16E.2000106@huawei.com> (raw)
In-Reply-To: <CA+rpMb+xL4g5bzGQhUe7kFkCmpH3VwGXsVP3zypW1w6366gAkw@mail.gmail.com>
On 2015/3/10 23:16, Gaurav Minocha wrote:
> Hi Rob,
>
> On Mar 10, 2015 7:51 AM, "Rob Herring" <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote:
>>
>> On Tue, Mar 10, 2015 at 9:44 AM, Rob Herring <robherring2@gmail.com <mailto:robherring2@gmail.com>> wrote:
>> > On Sun, Mar 8, 2015 at 9:35 PM, Wang Long <long.wanglong@huawei.com <mailto:long.wanglong@huawei.com>> wrote:
>> >> Since the directory "drivers/of/testcase-data" is renamed
>> >> to "drivers/of/unittest-data". so we should update the path
>> >> in the of_selftest.txt.
>>
>> [...]
>>
>> >> -Before executing OF selftest, it is required to attach the test data to
>> >> +Before executing OF unittest, it is required to attach the test data to
>> >> machine's device tree (if present). So, when selftest_data_add() is called,
>> >
>> > This one too.
>>
>> Or not. The functions are all still "selftest". Not sure why Grant
>> left all those...
>
> I will send a patch to replace the selftest with unitest also will update the document if required..
>
Hi Gaurav, Rob
I have done the work. before replacing the selftest with unittest, i will fix some error in OF unittest.
Please review my patch, and give me some advices.
Thanks.
Best Regards
Wang Long
>>
>> Rob
>
next prev parent reply other threads:[~2015-03-11 3:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 2:35 [PATCH v2 1/2] Documentation: update the of_selftest.txt Wang Long
2015-03-09 2:35 ` [PATCH v2 2/2] Documentation: rename of_selftest.txt to of_unittest.txt Wang Long
2015-03-10 14:44 ` [PATCH v2 1/2] Documentation: update the of_selftest.txt Rob Herring
[not found] ` <CAL_JsqLgxCQW==4YQrX193g+x22d1iL2jBGY4CSMnq7cQcSgZQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-10 14:50 ` Rob Herring
2015-03-10 15:16 ` Gaurav Minocha
2015-03-11 3:07 ` long.wanglong [this message]
2015-03-28 1:37 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FFB16E.2000106@huawei.com \
--to=long.wanglong@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gaurav.minocha.os@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peifeiyue@huawei.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).