From: "Herrenschmidt, Benjamin" <benh@amazon.com>
To: "robh@kernel.org" <robh@kernel.org>,
"segher@kernel.crashing.org" <segher@kernel.crashing.org>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"saravanak@google.com" <saravanak@google.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"conor@kernel.org" <conor@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling
Date: Thu, 5 Dec 2024 22:01:29 +0000 [thread overview]
Message-ID: <54b34ac1296dd6711bda5239069d5e3b436bbc8f.camel@amazon.com> (raw)
In-Reply-To: <CAL_JsqL5FHPNQWGdBEz9UpD7cq3We-czPV8OmwD=0w5Eu10=kA@mail.gmail.com>
On Mon, 2024-12-02 at 16:55 -0600, Rob Herring wrote:
> /* Look for this #address-cells. We have to implement the old linux
> * trick of looking for the parent here as some device-trees rely on it
> */
>
> Maybe that's from some system long dropped and we don't need it
> anymore. I have no idea. That's what I'm trying to find out with this
> patch.
>
> We also don't really have a way to distinguish OF from FDT (where we'd
> need to). It is somewhat just by arch, but PPC always passes an FDT to
> the kernel for both FDT and OF systems.
I probably wrote that :-)
The little I can remember, I think is there are many cases of old DTs
(esp. old Apple ones) missing the "empty" ranges property in some nodes
to indicate that the parent and child address spaces are identical.
I honestly don't remember the specifics, but this is something I did
hit a few times in the past.
Cheers,
Ben.
next prev parent reply other threads:[~2024-12-05 22:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20241108110444eucas1p20cbed7533af31573dac30dbb435c3d9d@eucas1p2.samsung.com>
2024-11-06 17:10 ` [PATCH v2] of: WARN on deprecated #address-cells/#size-cells handling Rob Herring (Arm)
2024-11-07 11:35 ` Michael Ellerman
2024-11-08 8:48 ` Geert Uytterhoeven
2024-11-14 2:07 ` Michael Ellerman
2024-11-14 12:54 ` Segher Boessenkool
2024-11-15 14:10 ` Rob Herring
2024-11-26 3:36 ` Michael Ellerman
2024-11-27 21:42 ` Segher Boessenkool
2024-12-02 14:18 ` Rob Herring
2024-12-02 22:04 ` Segher Boessenkool
2024-12-02 22:55 ` Rob Herring
2024-12-05 22:01 ` Herrenschmidt, Benjamin [this message]
2024-11-08 11:04 ` Marek Szyprowski
2024-11-08 13:25 ` Rob Herring
2024-11-08 15:28 ` Marek Szyprowski
2024-11-08 13:26 ` Steven Price
2024-11-08 14:04 ` Rob Herring
2024-11-08 14:33 ` Steven Price
2024-11-08 14:58 ` Rob Herring
2024-11-08 15:29 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54b34ac1296dd6711bda5239069d5e3b436bbc8f.camel@amazon.com \
--to=benh@amazon.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).