public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node
@ 2026-02-18 18:48 Tomer Maimon
  2026-02-18 19:17 ` Krzysztof Kozlowski
  2026-02-19  9:33 ` Andrew Jeffery
  0 siblings, 2 replies; 3+ messages in thread
From: Tomer Maimon @ 2026-02-18 18:48 UTC (permalink / raw)
  To: andrew
  Cc: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
	benjaminfair, robh, krzk+dt, conor+dt, openbmc, devicetree,
	linux-kernel

The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog
node, but this property is not used by any upstream driver and is not
documented in the NPCM watchdog binding. Since it was never reviewed and
does not form part of the DT ABI, it can be safely removed.

Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
 arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
index 24133528b8e9..c781190b42c5 100644
--- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
+++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
@@ -145,7 +145,6 @@ watchdog0: watchdog@801c {
 				reg = <0x801c 0x4>;
 				status = "disabled";
 				clocks = <&refclk>;
-				syscon = <&gcr>;
 			};
 
 			watchdog1: watchdog@901c {
@@ -154,7 +153,6 @@ watchdog1: watchdog@901c {
 				reg = <0x901c 0x4>;
 				status = "disabled";
 				clocks = <&refclk>;
-				syscon = <&gcr>;
 			};
 
 			watchdog2: watchdog@a01c {
@@ -163,7 +161,6 @@ watchdog2: watchdog@a01c {
 				reg = <0xa01c 0x4>;
 				status = "disabled";
 				clocks = <&refclk>;
-				syscon = <&gcr>;
 			};
 		};
 	};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node
  2026-02-18 18:48 [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node Tomer Maimon
@ 2026-02-18 19:17 ` Krzysztof Kozlowski
  2026-02-19  9:33 ` Andrew Jeffery
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-18 19:17 UTC (permalink / raw)
  To: Tomer Maimon, andrew
  Cc: avifishman70, tali.perry1, venture, yuenn, benjaminfair, robh,
	krzk+dt, conor+dt, openbmc, devicetree, linux-kernel

On 18/02/2026 19:48, Tomer Maimon wrote:
> The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog
> node, but this property is not used by any upstream driver and is not
> documented in the NPCM watchdog binding. Since it was never reviewed and
> does not form part of the DT ABI, it can be safely removed.

"Safely" is not certain or not true, because other users might rely on
that, but that's acceptable impact of undocumented ABI.

However such wording should be avoided, because it creates impression
that it is safe which later might be used by other developers ("but I
saw patch saying it is safe...").

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>  arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index 24133528b8e9..c781190b42c5 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -145,7 +145,6 @@ watchdog0: watchdog@801c {
>  				reg = <0x801c 0x4>;
>  				status = "disabled";
>  				clocks = <&refclk>;
> -				syscon = <&gcr>;
>  			};
>  
>  			watchdog1: watchdog@901c {
> @@ -154,7 +153,6 @@ watchdog1: watchdog@901c {
>  				reg = <0x901c 0x4>;
>  				status = "disabled";
>  				clocks = <&refclk>;
> -				syscon = <&gcr>;
>  			};
>  
>  			watchdog2: watchdog@a01c {
> @@ -163,7 +161,6 @@ watchdog2: watchdog@a01c {
>  				reg = <0xa01c 0x4>;
>  				status = "disabled";
>  				clocks = <&refclk>;
> -				syscon = <&gcr>;
>  			};
>  		};
>  	};


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node
  2026-02-18 18:48 [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node Tomer Maimon
  2026-02-18 19:17 ` Krzysztof Kozlowski
@ 2026-02-19  9:33 ` Andrew Jeffery
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Jeffery @ 2026-02-19  9:33 UTC (permalink / raw)
  To: Tomer Maimon
  Cc: avifishman70, tali.perry1, venture, yuenn, benjaminfair, robh,
	krzk+dt, conor+dt, openbmc, devicetree, linux-kernel

On Wed, 18 Feb 2026 20:48:00 +0200, Tomer Maimon wrote:
> The NPCM8XX DTSI currently includes a 'syscon' phandle in the watchdog
> node, but this property is not used by any upstream driver and is not
> documented in the NPCM watchdog binding. Since it was never reviewed and
> does not form part of the DT ABI, it can be safely removed.
> 
> 

Thanks, I've applied this to the BMC tree.

-- 
Andrew Jeffery <andrew@codeconstruct.com.au>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-19  9:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-18 18:48 [PATCH v1] arm64: dts: nuvoton: drop unused syscon property from watchdog node Tomer Maimon
2026-02-18 19:17 ` Krzysztof Kozlowski
2026-02-19  9:33 ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox