From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D02C1BE5D for ; Mon, 5 Feb 2024 06:12:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707113570; cv=none; b=YtdkhJTXc1C0Y9O59V/K0W1bKl3Fbb9nN5sO7+OsLp9kob5n809SpsQLJrPNM21f5/QDuvgHOvIACPqrsVVWAk9S8POvQlkNjTExBehutrgbG6mYnO/vLvdjEEcXAQ7MuRbKwQqtxqKiBBfKKVzwVhqa6w2pMhYeOPrc7SLYhcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707113570; c=relaxed/simple; bh=AWjSQ6dM2gKtx0a1QmVBUdvVFBwjjsRw26vaIXY9PEs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N1haP0ZOKQVz4h/wTI7KnBUK7z2Tzze4u5aL83WFvztxievPOgU1SW91LtJ6ni/q2d3+PMxrgddAdutv/8gmjmjxluTBlddUt5I/D27YYGIHK9vtvmM8NhucwHSTSlfGYgEMXJZNJzG2Faz50bwkARvnhHBMrurBvdwYQfFhMA8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=fRaIQl0I; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="fRaIQl0I" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33b29b5ea86so1221457f8f.1 for ; Sun, 04 Feb 2024 22:12:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1707113567; x=1707718367; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jdBwXVM+SOAESELO/ytwkxUYV96TJJe0V6iZHZRVYmM=; b=fRaIQl0InGiN8ZcqVcWINoHkUFNZdXo8aS4BA4Xe0/lZ/oE02B9wEXaSQoKD8ltyc2 F/rWomMuGqZ9owzHmjnpbLSzBfO/fVFA/O1IdhxwHu1KHW6rjHzET1Q0I8HbhQ2c+1sn exdGq2TpS9CFUvxElnv8sxQkwO5rIkwvpGez4lbk6S4tLsrF1IPC1EpeW5aAVdgrM2Pf HN6l3hQjHbYdhJ093EDqiw3092DIREQGvWedIcJEDrHKzM2KjzLdroTZ5G3QZFQWzeXx zmFP9s1oVuuPYRurqyqle6iWvq6h3+ySI2DZqqWd/CZCxxzU7AXcIURc5mAMcLibQh7A r5Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707113567; x=1707718367; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jdBwXVM+SOAESELO/ytwkxUYV96TJJe0V6iZHZRVYmM=; b=V5xGvVuo4+qId/sM2s/s7FKS6FaazqC/UPKELYMcWqN9Fd/jaukkygfM11KjYnqgLK kHfTlLlIyGsQWrXcSKE+Qlapw5ChML541kLyBy5spv7Vtg2r4FrWMUq/3MqbC/TDufwa aHh2GwCovQ5atfHfm/qPnJ8MABiK5ChHBQxiZsC8I/QtdN6FbHwTmX3Pz8M6TIAOD/p7 vqWZfdlHIol9x6gK5yMQcDksf9wH7Y/pj+Ca4jsjLegoAk/bWGMKsjwyDY/zWfIHkT1k ek0jkGiA/Wljf9m4Hv1hzJa2aNAgOMsqqajVzJPhSwnm2QMT/39NsU1ZvbaCUNDshn+G FJPg== X-Gm-Message-State: AOJu0YwduVImPPxo1jv6kA6TXOa3KMr0eGUAbQ/l+401R1osWN5fZPj4 dDlKzmncGZeSClWWScuzZhoLv8Gg2kNb5WsMzkzzSEBBZ0gG1ZceQRSIxfUlwqs= X-Google-Smtp-Source: AGHT+IHBl+UkMri4ML2Fx6tsedZ/8KR1gRyMF6CY+XVovF5fGEV95OwcwH6JYbJ9dCgk06wPP8xsSA== X-Received: by 2002:a5d:47a2:0:b0:33b:4197:75dc with SMTP id 2-20020a5d47a2000000b0033b419775dcmr234935wrb.14.1707113566851; Sun, 04 Feb 2024 22:12:46 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWPhXf6VHwYhyci11Q+EWL+w6Br2kQpm3ghemyLnvqzSMQH9s0mDxe08St6xFvT3e5p7hJp4nrH/Z58MHLYA026fsUopecCJf3T8Zif/I0Dr0d26m/aJg+PdrSFH4Vz25cuWO6H2uhCrx2nOQ5ReLKsw/EtRbXwGHtS0h8S56ZxLDuKhlUVgQipc4utfxR2DwWX5Wmql6BRRBdW863eySR/zUSWc94RDP0pOTNMEz8Ho7mljzgqOssvW05c/cY7THxDxwrJy6JckAMdiYC0eiqAVJeJuw9rFEl+6V7xKvKJT43OWGY/KeBH8v8So/J7hN71BOHMfpsVuFhoOD5ChWAXeBCQGq7zV9JRInsDMTcN8cq9H7rxvf44CvMEvKrW7q0KH2E0B1652qtK6XYkqy460hKYVbd4woDjhw/Uno82ggNEJCUDtDZXLANTVaaRKOp2Zrf69K+t8KRSdqZRocpACTEGMPmRlbTEG62OImeVJInGz6V3Yf44wGugY6x+cx88eydj Received: from [192.168.50.4] ([82.78.167.154]) by smtp.gmail.com with ESMTPSA id v23-20020adfa1d7000000b0033b37fe0577sm2604930wrv.54.2024.02.04.22.12.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 22:12:46 -0800 (PST) Message-ID: <54cd6cdb-0dc5-497b-aada-23f53aff402d@tuxon.dev> Date: Mon, 5 Feb 2024 08:12:44 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM To: Biju Das , "wim@linux-watchdog.org" , "linux@roeck-us.net" , "robh@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "p.zabel@pengutronix.de" , "geert+renesas@glider.be" , "magnus.damm@gmail.com" Cc: "linux-watchdog@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Claudiu Beznea References: <20240202075849.3422380-1-claudiu.beznea.uj@bp.renesas.com> <20240202075849.3422380-2-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Biju, On 02.02.2024 10:29, Biju Das wrote: >>> -----Original Message----- >>> From: Biju Das >>> Sent: Friday, February 2, 2024 8:03 AM >>> Subject: RE: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM >>> >>> Hi Claudiu Beznea, >>> >>>> -----Original Message----- >>>> From: Claudiu >>>> Sent: Friday, February 2, 2024 7:59 AM >>>> Subject: [PATCH v3 1/8] watchdog: rzg2l_wdt: Select PM >>>> >>>> From: Claudiu Beznea >>>> >>>> The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the >>>> clocks are enabled though pm_runtime_* specific APIs). To avoid >>>> building a driver that doesn't work make it depend on CONFIG_PM. >>>> >>>> Suggested-by: Guenter Roeck >>>> Signed-off-by: Claudiu Beznea >>>> --- >>>> >>>> Changes in v3: >>>> - make driver depend on PM; with that the "unmet direct dependency" >>>> Reported-by: kernel test robot >>>> was also fixed >>>> - adapt commit message >>>> >>>> Changes in v2: >>>> - this patch is new >>>> >>>> drivers/watchdog/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig >>>> index 7d22051b15a2..c9abe8f307bb 100644 >>>> --- a/drivers/watchdog/Kconfig >>>> +++ b/drivers/watchdog/Kconfig >>>> @@ -910,7 +910,7 @@ config RENESAS_RZN1WDT >>>> >>>> config RENESAS_RZG2LWDT >>>> tristate "Renesas RZ/G2L WDT Watchdog" >>>> - depends on ARCH_RENESAS || COMPILE_TEST >>>> + depends on (ARCH_RENESAS && PM) || COMPILE_TEST >>> >>> Since you are touching here, maybe ARCH_RZG2L?? like other RZ/G2L >> drivers. >> >> Also RZ/V2M "ARCH_R9A09G011" as both these families using same driver. Ok, I'll have another patch for that. > > Also commit header it is "Depend on" not "Select"? Ok! Thank you, Claudiu Beznea > > Cheers, > Biju