From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9C1C43334 for ; Thu, 14 Jul 2022 12:36:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239060AbiGNMgp (ORCPT ); Thu, 14 Jul 2022 08:36:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239402AbiGNMgl (ORCPT ); Thu, 14 Jul 2022 08:36:41 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08D125D594; Thu, 14 Jul 2022 05:36:28 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id EEBE16601A3F; Thu, 14 Jul 2022 13:36:25 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657802186; bh=fcsVlf6xPjzt5yZzyb/7Pgp8srcKQ+iZoypPGWQLnpI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=B7VNKzC74eawIHUeNRTyXOmvtwhbg0XtsCGVXt8OjKqpnhveB0pWJUeCCW66bzZlv 5lquChQXuumBdUj6Y2KpkdaIR/CWqjKd/FfszSitYJjTngjWzoK97g26A218BvQwx3 UXkZSDDwxvDy/jQYp5uVPyLxfiilKoiNmJvzOvMTigVjhlyoxgDazhHAd5Pw8HM1Gh +LBDYRzrCG4QItjnCf/QOTIBumdxFqwFHNxZuTwWpChCL2VK9byqSaBsiUptoqBMfN MOp4UwwhrstyFnyv+wNLFR40buO2nOMhY4AHOJlhgRfp8tBR8hj4xUuX9+NbJNAMyd KcLRCWCuos3HQ== Message-ID: <54d573df-fa3c-b2d2-e470-c157ac06bcf3@collabora.com> Date: Thu, 14 Jul 2022 14:36:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 02/19] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Content-Language: en-US To: Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Rob Herring , Krzysztof Kozlowski , Lee Jones , Matthias Brugger , Chun-Jie Chen , MandyJH Liu , Weiyi Lu Cc: iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220714122837.20094-1-tinghan.shen@mediatek.com> <20220714122837.20094-3-tinghan.shen@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220714122837.20094-3-tinghan.shen@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 14/07/22 14:28, Tinghan Shen ha scritto: > The max clock items for the dts node with compatible > 'mediatek,mt8195-smi-sub-common' should be 3. > > However, the dtbs_check of such node will get following message, > arch/arm64/boot/dts/mediatek/mt8195-evb.dtb: smi@14010000: clock-names: ['apb', 'smi', 'gals0'] is too long > From schema: Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > > It's because the 'mediatek,mt8195-smi-sub-common' compatible incorrectly > matches the 'else' conditions for gen2 HW without gals. > > Rewrite the 'else' condition to specifically identify the compatibles > that utilizing gen2 HW without gals. > > Signed-off-by: Tinghan Shen Reviewed-by: AngeloGioacchino Del Regno