From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96227C4332F for ; Mon, 17 Oct 2022 08:13:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230044AbiJQINP (ORCPT ); Mon, 17 Oct 2022 04:13:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230178AbiJQINK (ORCPT ); Mon, 17 Oct 2022 04:13:10 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71F665C943 for ; Mon, 17 Oct 2022 01:13:06 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id i131-20020a1c3b89000000b003c6c154d528so5085496wma.4 for ; Mon, 17 Oct 2022 01:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uN5hZ0Pnut2v70eOdEnS4yEwy3E1TJfU7I2780Pammg=; b=NE4EujS6yyZ0ozOe7XZmcphLCO5NRBx7LaBteIf7U5Y9Gy2VGxPskyLIKWXARAKuqL +H9gPJwExlT4yMye0/nqZY1SNiusw8Q73EWfXOQBzUBaQJRawfeqSSB5CpmoB7wH9MEY Kq/qBQmyghRPXC/zy7MMQDubDlNgtm9VxUggA7H4lUzQuszyXiCIkDr0oIAu9iwDIUFz 5Fen+jTS6Jrg5OZFTeEiB+2btXZhUZi8T0R8AsqqKU19pwZU+9obaUfq6LBpXCQ3H4rC tEvOQlsLDbM7UyDCCsjrur/tU95i2+3C9r5msHCAeOixCpfPV9Q/G6oLqPqMnCpK+p2u 339w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uN5hZ0Pnut2v70eOdEnS4yEwy3E1TJfU7I2780Pammg=; b=PpJBkclbv6Ho+4dbZOHRpy++Swnzea7oo3JfYCANgNX1+b/OR/6RW68fPUH78BSPzd an2EVAII1C9TYVYpMHfEnScH1kPEgHpusMdyD3FHCQePUueUV4ZcABUI7YThVj6QcDfE URm26ga5jKFGVVYWcszIzgICwhbeM0IF/U9vdSzFR3Hlnykxx3eaAQbg1yzZsGoIWQI+ tnNsgm6qy1adqsABhx5BiLZYpq5b/AFhtUfs3wbtH4WkU3DnBQ2S5TmIwYpSKerqC82H +zHfXLMtyXQvojbnFcba3TGbiNxcx+91bgfWjylIkexl/T6OpQJObMfTI8CzrTRBwp3Z ximg== X-Gm-Message-State: ACrzQf1GjypS013U0HVLWkgq6lvLoTF+bb2VEkxe3WTK9BLF74UJsErM va7QWcW0QhFstoiIxsIIh9WWMvG0G7GaHRPy X-Google-Smtp-Source: AMsMyM4n5du8KaTXE1LWeN7qR0OfmlCKEqOOdejKwVtT/by89Is0RX8yrcULvEmZNQrZfJDjASCG3A== X-Received: by 2002:a05:600c:190a:b0:3a8:43b8:53e3 with SMTP id j10-20020a05600c190a00b003a843b853e3mr6664364wmq.4.1665994384998; Mon, 17 Oct 2022 01:13:04 -0700 (PDT) Received: from [192.168.27.65] (home.beaume.starnux.net. [82.66.176.246]) by smtp.gmail.com with ESMTPSA id az25-20020a05600c601900b003b497138093sm9636827wmb.47.2022.10.17.01.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 01:13:04 -0700 (PDT) Message-ID: <54e4047f-cd82-c3f7-a987-7ced4fec0dbb@linaro.org> Date: Mon, 17 Oct 2022 10:13:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 2/4] arm64: dts: qcom: msm8998-oneplus-cheeseburger: fix backlight pin function Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221011213145.122879-1-krzysztof.kozlowski@linaro.org> <20221011213145.122879-2-krzysztof.kozlowski@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20221011213145.122879-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/10/2022 23:31, Krzysztof Kozlowski wrote: > There is no "normal" function, so use "gpio" for backlight button pin > configuration. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > index ef2a88a64d32..122f6c25220e 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts > @@ -35,7 +35,7 @@ &pmi8998_gpio { > button_backlight_default: button-backlight-state { > pinconf { > pins = "gpio5"; > - function = "normal"; > + function = "gpio"; > bias-pull-down; > qcom,drive-strength = ; > }; Perhaps a Fixes tag would be needed here ? Reviewed-by: Neil Armstrong