From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7126AC6FA99 for ; Fri, 10 Mar 2023 11:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229767AbjCJLDw (ORCPT ); Fri, 10 Mar 2023 06:03:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbjCJLDu (ORCPT ); Fri, 10 Mar 2023 06:03:50 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 078026B32B for ; Fri, 10 Mar 2023 03:03:49 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id c18so3113186wmr.3 for ; Fri, 10 Mar 2023 03:03:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678446227; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f2cqaQ7P3+QlFidPWZAuEu2duN2TwjDZBG31X7oHFQk=; b=pXW/fXq1BSv1IPdAh0bFQhD5mDGZW4TKqVFC7WBT4PG+9tpctEcpKkMtEzEXovXcbW b2NA7ywFBB3/PR4SineOULUiVDAoZ6PMUYM23RuHN9DVWAApvqttgaV3KQI/ruILANSB V0CA8pJ1fAIHS+tQmWgy+/uRBKY1dRdA+saFYqpZa4dtYXkUkarkcClKwoF5IPohwM0b 62hgP1Oc0CAwxdKakHjx8PmLsgen8XdUumBT1bak1t78tQtuesCrV5Ab7ZG4lE2fukZm qcWdWXoL3yTu0BujG5pNCqro5Dn2RL07aC/hU10qUJGSak/KT+TjAu44XEK4PaafRw6i AlxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678446227; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f2cqaQ7P3+QlFidPWZAuEu2duN2TwjDZBG31X7oHFQk=; b=gnfkltTtYOfmSV4d3WyGj8ffFbcJIqV2yv7EUHuzclmWmPyTxHFCZBkxUGfsRMDMEJ pOFDTAfJ/nZ8+tSmNSEHqyLAFg84PBZjGB9Xyro0pfNYFFJk/tz3kFG2nW3QF+nhOfEe C9g47g7Cpl2Qo7PwsSHEMo9tSgkDNHuDTgv3UMxaRaW+4UxczsKSd9/hA0oJ2/CIVGZf yyTw/YEO0FCwePmeuSquIk6JgXt7huYYkVqgS1GQ2BcP772ZZVbSYiNTw2/fkwKLYzfr 8SRustqSyKs4CI8rw1QLDir8qhoR3DWnRetJNUXqaxUIUrnpw4zUYP1UhSp843+hNtto OpWw== X-Gm-Message-State: AO0yUKUauo6De+sMp2V/75EYp9Tp9xVH+TgCy32SUGU+/DtuJFzoIAjR 5yrh41345KhYdOWivrKu5pkovQ== X-Google-Smtp-Source: AK7set9MxonTrQIssC7Z8UMeHgkpnv2EPMV7DEIuDlDQUmWtedQcdBRMlZISj50c2oYgxOBjDojdNA== X-Received: by 2002:a05:600c:4450:b0:3eb:36fa:b791 with SMTP id v16-20020a05600c445000b003eb36fab791mr2152882wmn.31.1678446227516; Fri, 10 Mar 2023 03:03:47 -0800 (PST) Received: from [192.168.1.195] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id d20-20020a1c7314000000b003e1202744f2sm2582484wmb.31.2023.03.10.03.03.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Mar 2023 03:03:46 -0800 (PST) Message-ID: <54e7ee75-6035-c2e9-fb8b-fe96adbb571a@linaro.org> Date: Fri, 10 Mar 2023 11:03:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v3 17/20] nvmem: layouts: sl28vpd: Add new layout driver Content-Language: en-US To: Miquel Raynal , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Michael Walle , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Robert Marko , Luka Perkov , Thomas Petazzoni , Rob Herring , Frank Rowand , devicetree@vger.kernel.org References: <20230308153200.682248-1-miquel.raynal@bootlin.com> <20230308153200.682248-18-miquel.raynal@bootlin.com> From: Srinivas Kandagatla In-Reply-To: <20230308153200.682248-18-miquel.raynal@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/03/2023 15:31, Miquel Raynal wrote: > + > +static int __init sl28vpd_init(void) > +{ > + return nvmem_layout_register(&sl28vpd_layout); > +} > + > +static void __exit sl28vpd_exit(void) > +{ > + nvmem_layout_unregister(&sl28vpd_layout); > +} > + > +module_init(sl28vpd_init); > +module_exit(sl28vpd_exit); Looking at this pattern in two drivers, we could come up with some helper macro like. #define module_nvmem_layout_driver(__layout_driver) \ module_driver(__layout_driver, nvmem_layout_register, \ nvmem_layout_unregister) --srini