Devicetree
 help / color / mirror / Atom feed
From: Daniel Drake <dan@reactivated.net>
To: Jim Quinlan <james.quinlan@broadcom.com>
Cc: "Joerg Roedel (AMD)" <joro@8bytes.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	nick.hollinghurst@raspberrypi.com, Jason Gunthorpe <jgg@ziepe.ca>,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v4 2/5] dt-bindings: iommu: Add Broadcom BCM2712 IOMMU
Date: Sat, 5 Sep 2026 20:12:45 +0100	[thread overview]
Message-ID: <54e99476-1824-4dc8-b0e3-8d95cfb0ca82@reactivated.net> (raw)
In-Reply-To: <CA+-6iNyAU9uw1QyA8TaBWOvhWuxe=DdbeEzoHgM9Gk3TSsSccA@mail.gmail.com>

Hi!,

On 03/09/2026 18:36, Jim Quinlan wrote:
> What are your thoughts on allowing the iommu work without the cache
> property, ie having its presence be optional?  I work on the Broadcom
> version of the Rpi4/5 SoCs,  and  (a) on certain workloads the cache
> slightly degrades performance or (b) on some chips there is no cache
> associated with a specific iommu.  This is probably on me to implement
> these possibilities, but I just wanted to give you a heads-up.


For (a) I think the DT must encode the relationship between iommu & 
iommuc in any case, because the DT's job is to describe the hardware.

If the user wishes to disable use of the iommu cache then that would be 
a software configuration choice. This control could perhaps be exposed 
via a module parameter, or by iommu_device_sysfs_add() to expose a 
writable attribute. Ultimately which approach is suitable would be a 
decision of the iommu subsystem maintainers.

For (b) we could just make the property optional when support for such a 
chip arrives, or alternatively we could use a different compatible 
string for the cache-less iommus and have the cache property only 
required for certain specific compatible strings (see 
mediatek,iommu.yaml for an example where some properties are only 
required for certain compatible values).

I'd be happy to review patches for these cases once the driver support 
is added.

Thanks!
Daniel


  reply	other threads:[~2026-09-05 19:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 17:57 [PATCH v4 0/5] Add support for Broadcom BCM2712 IOMMU driver (Raspberry Pi 5) Daniel Drake
2026-09-02 17:57 ` [PATCH v4 1/5] iommu_pt: Fix test_pgsize_boundary() failure on narrow-OA formats Daniel Drake
2026-09-02 17:57 ` [PATCH v4 2/5] dt-bindings: iommu: Add Broadcom BCM2712 IOMMU Daniel Drake
2026-09-02 18:03   ` sashiko-bot
2026-09-03 17:36   ` Jim Quinlan
2026-09-05 19:12     ` Daniel Drake [this message]
2026-09-02 17:57 ` [PATCH v4 3/5] iommu/generic_pt: Add Broadcom BCM2712 page table format Daniel Drake
2026-09-02 17:57 ` [PATCH v4 4/5] iommu: Add Broadcom BCM2712 IOMMU driver Daniel Drake
2026-09-02 18:12   ` sashiko-bot
2026-09-02 22:15   ` Daniel Drake
2026-09-03 18:00     ` Jim Quinlan
2026-09-02 17:57 ` [PATCH v4 5/5] arm64: dts: broadcom: bcm2712: Add GPU IOMMU and IOMMU cache nodes Daniel Drake
2026-09-03 18:14 ` [PATCH v4 0/5] Add support for Broadcom BCM2712 IOMMU driver (Raspberry Pi 5) Jim Quinlan
2026-09-05 19:25   ` Daniel Drake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54e99476-1824-4dc8-b0e3-8d95cfb0ca82@reactivated.net \
    --to=dan@reactivated.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=iommu@lists.linux.dev \
    --cc=james.quinlan@broadcom.com \
    --cc=jgg@ziepe.ca \
    --cc=joro@8bytes.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nick.hollinghurst@raspberrypi.com \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox