devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>,
	Michal Wilczynski <m.wilczynski@samsung.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	drew@pdp7.com, guoren@kernel.org, wefu@redhat.com,
	jassisinghbrar@gmail.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu,
	m.szyprowski@samsung.com
Subject: Re: [PATCH v4 2/3] dt-bindings: mailbox: Add thead,th1520-mailbox bindings
Date: Wed, 16 Oct 2024 08:31:23 +0200	[thread overview]
Message-ID: <54fd467b-8077-454f-ae6c-14bb782cbe3a@kernel.org> (raw)
In-Reply-To: <f1c1af8c-18e0-433d-a61c-90080919378f@sifive.com>

On 16/10/2024 01:14, Samuel Holland wrote:
>> +  reg-names:
>> +    items:
>> +      - const: local
>> +      - const: remote-icu0
>> +      - const: remote-icu1
>> +      - const: remote-icu2
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  '#mbox-cells':
>> +    const: 2
>> +    description: |
>> +      Specifies the number of cells needed to encode the mailbox specifier.
>> +      The mailbox specifier consists of two cells:
>> +        - Destination CPU ID.
>> +        - Type, which can be one of the following:
>> +            - 0:
>> +                - TX & RX channels share the same channel.
>> +                - Equipped with 7 info registers to facilitate data sharing.
>> +                - Supports IRQ for signaling.
>> +            - 1:
>> +                - TX & RX operate as doorbell channels.
>> +                - Does not have dedicated info registers.
>> +                - Lacks ACK support.
> 
> It appears that these types are not describing hardware, but the protocol used
> by the Linux driver to glue two unidirectional hardware channels together to
> make a virtual bidirectional channel. This is really the responsibility of the
> mailbox client to know what protocol it needs, not the devicetree.
> 

Hm, where is the DTS with consumers of this mailbox provider?

Best regards,
Krzysztof


  reply	other threads:[~2024-10-16  6:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20241014123409eucas1p2a3a3f085c0630073326ca299a870f3ee@eucas1p2.samsung.com>
2024-10-14 12:33 ` [PATCH v4 0/3] Introduce support for T-head TH1520 Mailbox Michal Wilczynski
     [not found]   ` <CGME20241014123410eucas1p2d4d636b390cd5b426bbf37e493363663@eucas1p2.samsung.com>
2024-10-14 12:33     ` [PATCH v4 1/3] mailbox: Introduce support for T-head TH1520 Mailbox driver Michal Wilczynski
     [not found]   ` <CGME20241014123411eucas1p1f93d64ac9db9a6f77982500d4a0157f7@eucas1p1.samsung.com>
2024-10-14 12:33     ` [PATCH v4 2/3] dt-bindings: mailbox: Add thead,th1520-mailbox bindings Michal Wilczynski
2024-10-15 23:14       ` Samuel Holland
2024-10-16  6:31         ` Krzysztof Kozlowski [this message]
2024-10-20  7:31           ` Michal Wilczynski
2024-10-20  7:32         ` Michal Wilczynski
     [not found]   ` <CGME20241014123412eucas1p2144768f373a2e2de7f6d00e7b67f9328@eucas1p2.samsung.com>
2024-10-14 12:33     ` [PATCH v4 3/3] riscv: dts: thead: Add mailbox node Michal Wilczynski
2024-10-14 14:57       ` Emil Renner Berthing
2024-10-15 18:44         ` Michal Wilczynski
2024-10-17 11:20           ` Emil Renner Berthing
2024-10-14 18:31   ` [PATCH v4 0/3] Introduce support for T-head TH1520 Mailbox Drew Fustini
2024-10-15 22:03     ` Michal Wilczynski
2024-10-16 18:08       ` Drew Fustini
2024-10-22 11:54         ` Michal Wilczynski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54fd467b-8077-454f-ae6c-14bb782cbe3a@kernel.org \
    --to=krzk@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drew@pdp7.com \
    --cc=guoren@kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=m.szyprowski@samsung.com \
    --cc=m.wilczynski@samsung.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=samuel.holland@sifive.com \
    --cc=wefu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).