From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Richardson Subject: Re: [PATCH v3 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Date: Wed, 11 Mar 2015 10:05:51 -0700 Message-ID: <550075EF.30303@broadcom.com> References: <1426036669-21659-1-git-send-email-jonathar@broadcom.com> <1426036669-21659-2-git-send-email-jonathar@broadcom.com> <1426067197.4244.41.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1426067197.4244.41.camel@x220> Sender: linux-kernel-owner@vger.kernel.org To: Paul Bolle Cc: Dmitry Torokhov , Anatol Pomazau , Scott Branden , Grant Likely , Rob Herring , Ray Jui , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, bcm-kernel-feedback-list , devicetree@vger.kernel.org, Joe Perches , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala List-Id: devicetree@vger.kernel.org Hi Paul, Yes, I didn't notice that. I'll include it in the next patch. Thanks for the review. Jon On 15-03-11 02:46 AM, Paul Bolle wrote: > One nit is all I can report. > > On Tue, 2015-03-10 at 18:17 -0700, Jonathan Richardson wrote: >> --- a/drivers/input/touchscreen/Kconfig >> +++ b/drivers/input/touchscreen/Kconfig > >> +config TOUCHSCREEN_IPROC >> + tristate "IPROC touch panel driver support" >> + help >> + Say Y here if you want to add support for the IPROC touch >> + controller to your system. >> + >> + If unsure, say N. >> + >> + To compile this driver as a module, choose M here: the >> + module will be called iproc-ts. > > The module will be called "bcm_iproc_tsc", won't it? > >> --- a/drivers/input/touchscreen/Makefile >> +++ b/drivers/input/touchscreen/Makefile > >> +obj-$(CONFIG_TOUCHSCREEN_IPROC) += bcm_iproc_tsc.o > > > Paul Bolle >