From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Denzeel Oliva <wachiturroxd150@gmail.com>
Cc: alim.akhtar@samsung.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, krzk+dt@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-serial@vger.kernel.org, robh@kernel.org,
semen.protsenko@linaro.org
Subject: Re: [PATCH v1 2/3] dt-bindings: serial: samsung: add Exynos990 compatible
Date: Fri, 14 Feb 2025 06:42:14 +0000 [thread overview]
Message-ID: <55028ae3-ffab-41e8-b1ec-fb2098b65d7c@linaro.org> (raw)
In-Reply-To: <Z67Rm0HoEqGsiL/F@droid-r8s>
On 2/14/25 5:16 AM, Denzeel Oliva wrote:
> On Thu, Feb 13, 2025 at 07:20:22AM +0000, Tudor Ambarus wrote:
>> doesn't the 32 bit register restriction apply to uart as it applies to
>> SPI? If so, you shall probably fallback to gs101.
>
> Of course not, downstream of the UART serial driver there is nothing
> specified about 32-bit access restriction, nothing explicitly
> in the driver. [0]
>
> https://github.com/pascua28/android_kernel_samsung_s20fe/blob/3be539e9cd22b89ba3cc8282945a0c46ff27341d/drivers/tty/serial/samsung.c#L1543
that's very strange. uart and spi are part of the same USI IP, on the
same bus. I don't think you can have the same IP requiring 32 bit
accesses for SPI but allow 8-bit accesses for uart.
Maybe SPI can work with 8bit accesses? How did you test SPI and uart?
next prev parent reply other threads:[~2025-02-14 6:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 23:40 [PATCH v1 0/3] arm64: dts: exynos990: define all PERIC0/1 USI nodes Denzeel Oliva
2025-02-12 23:40 ` [PATCH v1 1/3] dt-bindings: samsung: usi: add exynos990-usi compatible Denzeel Oliva
2025-02-12 23:40 ` [PATCH v1 2/3] dt-bindings: serial: samsung: add Exynos990 compatible Denzeel Oliva
2025-02-13 7:20 ` Tudor Ambarus
2025-02-14 5:16 ` Denzeel Oliva
2025-02-14 6:42 ` Tudor Ambarus [this message]
2025-02-12 23:40 ` [PATCH v1 3/3] arm64: dts: exynos990: define all PERIC USI nodes Denzeel Oliva
2025-02-13 7:38 ` Tudor Ambarus
2025-02-14 6:17 ` Denzeel Oliva
2025-02-14 6:49 ` Tudor Ambarus
2025-02-14 15:39 ` Sam Protsenko
2025-02-14 8:20 ` [PATCH v1 0/3] arm64: dts: exynos990: define all PERIC0/1 " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55028ae3-ffab-41e8-b1ec-fb2098b65d7c@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=wachiturroxd150@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).