From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Marek Belisko <marek@goldelico.com>
Cc: bcousson@baylibre.com, tony@atomide.com, eballetbo@gmail.com,
javier@dowhile0.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jarkko.nikula@bitmer.com,
hns@goldelico.com
Subject: Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property
Date: Fri, 13 Mar 2015 13:48:46 +0200 [thread overview]
Message-ID: <5502CE9E.1020705@ti.com> (raw)
In-Reply-To: <38159868.RLZZTyUOlK@wuerfel>
On 03/13/2015 01:05 PM, Arnd Bergmann wrote:
> On Thursday 12 March 2015 22:14:59 Marek Belisko wrote:
>> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> index 1ab6bc8..656165f 100644
>> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt
>> @@ -4,7 +4,6 @@ Required properties:
>> - compatible: "ti,omap-twl4030"
>> - ti,model: Name of the sound card (for example "omap3beagle")
>> - ti,mcbsp: phandle for the McBSP node
>> -- ti,codec: phandle for the twl4030 audio node
>
> As this was a required property, are you sure that no other operating system
> uses it?
>
> Even if not, you should probably change it to be an optional property, so
> that the existing dtbs do not become noncompliant after the change.
After I sent my Ack, I also started to think about the same thing. It is
better to change it to optional.
--
Péter
next prev parent reply other threads:[~2015-03-13 11:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 21:14 [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property Marek Belisko
2015-03-12 21:14 ` [PATCH 1/2] ARM: dts: omap3: Remove all references to " Marek Belisko
2015-03-12 21:14 ` [PATCH 2/2] Documentation: omap-twl4030: Remove " Marek Belisko
2015-03-13 11:05 ` Arnd Bergmann
2015-03-13 11:48 ` Peter Ujfalusi [this message]
2015-03-13 11:50 ` Belisko Marek
2015-03-13 7:09 ` [PATCH 0/2] ARM: devicetree: Remove unused " Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502CE9E.1020705@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=eballetbo@gmail.com \
--cc=hns@goldelico.com \
--cc=jarkko.nikula@bitmer.com \
--cc=javier@dowhile0.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).