From: Frank Rowand <frowand.list@gmail.com>
To: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: [Patch 5/5] dt: unittest: breadcrumbs to reduce pain of future maintainers
Date: Sat, 14 Mar 2015 00:04:24 -0700 [thread overview]
Message-ID: <5503DD78.5070808@gmail.com> (raw)
In-Reply-To: <5503C65F.4030000@gmail.com>
From: Frank Rowand <frank.rowand@sonymobile.com>
Fix warnings pointed out by checkpatch.
Checkpatch warns: externs should be avoided in .c files
Reducing pain for future maintainers - adding a comment so that anyone trying
to find where the extern data is created will be able to find it.
(grep will not find that location)
Signed-off-by: Frank Rowand <frank.rowand@sonymobile.com>
---
drivers/of/unittest.c | 4 ++++
1 file changed, 4 insertions(+)
Index: b/drivers/of/unittest.c
===================================================================
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -865,6 +865,10 @@ static int __init selftest_data_add(void
{
void *selftest_data;
struct device_node *selftest_data_node, *np;
+ /*
+ * __dtb_testcases_begin[] and __dtb_testcases_end[] are magically
+ * created by cmd_dt_S_dtb in scripts/Makefile.lib
+ */
extern uint8_t __dtb_testcases_begin[];
extern uint8_t __dtb_testcases_end[];
const int size = __dtb_testcases_end - __dtb_testcases_begin;
next prev parent reply other threads:[~2015-03-14 7:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 5:25 [Patch 0/5] dt: unittest: fix breakage and warnings Frank Rowand
2015-03-14 6:57 ` [Patch 1/5] dt: unittest: early return from test skips tests Frank Rowand
2015-03-28 3:58 ` Grant Likely
[not found] ` <5503C65F.4030000-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-14 6:59 ` [Patch 2/5] dt: unittest: typo in error string Frank Rowand
2015-03-14 7:00 ` [Patch 3/5] dt: unittest: add const where needed Frank Rowand
2015-03-14 7:02 ` [Patch 4/5] dt: unittest: reduce checkpatch noise - line after declarations Frank Rowand
2015-03-14 7:04 ` Frank Rowand [this message]
2015-03-28 2:55 ` [Patch 0/5] dt: unittest: fix breakage and warnings Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5503DD78.5070808@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).