From: Peter Hurley <peter@hurleysoftware.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>,
Rob Herring <robh@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [REGRESSION] "of: Fix premature bootconsole disable with 'stdout-path'" breaks console on tty0
Date: Mon, 16 Mar 2015 13:49:20 -0400 [thread overview]
Message-ID: <550717A0.3060603@hurleysoftware.com> (raw)
In-Reply-To: <55070544.9010908@redhat.com>
Hi Hans,
On 03/16/2015 12:31 PM, Hans de Goede wrote:
> Hi All,
>
> While updating my local working tree to 4.0-rc4 this morning I noticed that I no longer
> get console / kernel messages output on the hdmi output of my ARM board / on tty0
>
> This is caused by:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/of?id=2fa645cb2703d9b3786d850db815414dfeefa51d
>
> Reverting this commit fixes this for me.
>
> What is happening here is that the "add_preferred_console("stdout-path", 0, NULL);"
> happens before the tty0 registers stopping tty0 from becoming part of the console list
> since there already is a preferred console at that time.
>
> This is an undesirable behavior change caused by the commit in question, on boards
> where there is both video output, and a serial console configured through stdout-path
> we want to have console output on both as we do not know which of the 2 will actually
> be hooked up by the user.
I don't see this as a regression, but rather a misconfiguration.
1. Your DT indicates the stdout device is a serial console; that is
the expected outcome. Here's what ePAPR has to say on the chosen/stdout-path
property node:
"A string that specifies the full path to the node representing the device to be
used for boot console output. If the character ":" is present in the value it
terminates the path. The value may be an alias."
If the serial console is not the stdout device then the DT should not
claim it is.
2. The tty0 console is not now, and has never been, always enabled.
The tty0 console is only enabled when either,
a) there is no other console
b) when specified on the command line (ie., "console=tty0") or
by prom/dt.
Your situation is akin to adding the serial console to the command line; if
"console=tty0" is not also explicitly added, there is no boot console output
to tty0.
3. This same breakage will happen if any other device registers a console matching
the stdout-path at console_init() time (ie, with console_initcall() macro) before
the dummy console. The order in which consoles are inited via console_initcall()
is dependent on link order, so essentially not controllable across different
subsystems (or if there were consoles defined with the arch itself).
That said, I'll look into fixing your use-case automagically without requiring
configuration changes.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-03-16 17:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 16:31 [REGRESSION] "of: Fix premature bootconsole disable with 'stdout-path'" breaks console on tty0 Hans de Goede
2015-03-16 17:49 ` Peter Hurley [this message]
[not found] ` <550717A0.3060603-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-03-16 18:12 ` Hans de Goede
[not found] ` <55071D0C.2050700-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-16 18:23 ` Peter Hurley
2015-03-16 18:35 ` Hans de Goede
2015-03-16 19:46 ` Peter Hurley
[not found] ` <5507332B.5020504-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-03-17 16:48 ` Jon Masters
2015-03-17 17:47 ` Peter Hurley
[not found] ` <550868AF.8050201-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-03-18 0:13 ` Jon Masters
2015-03-18 13:00 ` Peter Hurley
2015-03-18 22:46 ` Jon Masters
[not found] ` <550A003C.4040100-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-19 11:46 ` Peter Hurley
2015-03-16 22:36 ` Peter Hurley
2015-03-17 8:20 ` Hans de Goede
2015-03-17 13:30 ` Rob Herring
[not found] ` <CAL_Jsq+dA3RDbakrkeMY07czs13bFFKCyETEXTzWxf+h1umBPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-17 13:43 ` Hans de Goede
[not found] ` <55082F9F.90909-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-03-17 14:20 ` Peter Hurley
2015-03-17 20:22 ` Peter Hurley
2015-03-17 0:19 ` Andreas Schwab
[not found] ` <87r3sowk51.fsf-hBGjKatGTSWzQB+pC5nmwQ@public.gmane.org>
2015-03-17 0:30 ` Peter Hurley
2015-03-17 0:35 ` Andreas Schwab
2015-03-17 0:46 ` Peter Hurley
2015-03-17 6:49 ` Geert Uytterhoeven
2015-03-17 18:27 ` Andreas Schwab
2015-03-17 19:35 ` Andreas Schwab
2015-03-17 19:44 ` Peter Hurley
2015-03-17 20:14 ` Peter Hurley
2015-03-17 22:26 ` Andreas Schwab
2015-03-17 8:25 ` Hans de Goede
2015-03-17 10:09 ` Leif Lindholm
[not found] ` <20150317100917.GM4278-t77nlHhSwNqAroYi2ySoxKxOck334EZe@public.gmane.org>
2015-03-17 10:11 ` Hans de Goede
2015-03-17 19:06 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550717A0.3060603@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).