From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: Re: [PATCH] Input: sun4i-ts - allow to adjust some settings via device-tree properties. Date: Wed, 18 Mar 2015 12:01:58 +0100 Message-ID: <55095B26.209@redhat.com> References: <1426175150-27005-1-git-send-email-karme@karme.de> <20150318103744.GR4638@lukather> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: <20150318103744.GR4638@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jens Thiele Cc: Dmitry Torokhov , Chen-Yu Tsai , Eduardo Valentin , Wolfram Sang , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 18-03-15 11:37, Maxime Ripard wrote: > On Thu, Mar 12, 2015 at 04:45:50PM +0100, Jens Thiele wrote: >> This commit introduces two new optional device-tree properties: >> "tp-sensitive-adjust": adjust sensitivity of pen down detection >> "filter-type": select median and averaging filter >> >> The previous fixed defaults, didn't work well for the Olimex >> A13-LCD10TS (I have). >> >> Signed-off-by: Jens Thiele >> --- >> .../devicetree/bindings/input/touchscreen/sun4i.txt | 19 +++++++++++++++++-- >> drivers/input/touchscreen/sun4i-ts.c | 17 +++++++++++++---- >> 2 files changed, 30 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt >> index 433332d..c93edfa 100644 >> --- a/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt >> +++ b/Documentation/devicetree/bindings/input/touchscreen/sun4i.txt >> @@ -8,8 +8,20 @@ Required properties: >> - #thermal-sensor-cells: shall be 0 >> >> Optional properties: >> - - allwinner,ts-attached: boolean indicating that an actual touchscreen is >> - attached to the controller >> + - allwinner,ts-attached : boolean indicating that an actual touchscreen >> + is attached to the controller >> + - allwinner,tp-sensitive-adjust : integer (4 bits) >> + adjust sensitivity of pen down detection >> + between 0 (least sensitive) and 15 >> + (defaults to 15) >> + - allwinner,filter-type : integer (2 bits) >> + select median and averaging filter >> + samples used for median / averaging filter >> + 0: 4/2 >> + 1: 5/3 >> + 2: 8/4 >> + 3: 16/8 >> + (defaults to 1) > > You shouldn't rely on any bits length in your binding. > > And this looks really more of a configuration option, and would be > better exposed through sysfs. Erm, no, this is to adjust for properties of the touchscreen, so this is hardware configuration, and as such definitely belongs in the dts. Regards, Hans