From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH/RFC v13 10/13] Documentation: leds: Add description of v4l2-flash sub-device Date: Wed, 18 Mar 2015 15:36:05 +0100 Message-ID: <55098D55.6050101@samsung.com> References: <1426175114-14876-1-git-send-email-j.anaszewski@samsung.com> <1426175114-14876-11-git-send-email-j.anaszewski@samsung.com> <20150318123957.GH11954@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150318123957.GH11954@valkosipuli.retiisi.org.uk> Sender: linux-leds-owner@vger.kernel.org To: Sakari Ailus , cooloney@gmail.com Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kyungmin.park@samsung.com, pavel@ucw.cz, rpurdie@rpsys.net, s.nawrocki@samsung.com List-Id: devicetree@vger.kernel.org Hi Sakari, On 03/18/2015 01:39 PM, Sakari Ailus wrote: > Hi Jacek, > > On Thu, Mar 12, 2015 at 04:45:11PM +0100, Jacek Anaszewski wrote: >> This patch extends LED Flash class documention by >> the description of interactions with v4l2-flash sub-device. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by: Kyungmin Park >> Acked-by: Sakari Ailus >> Cc: Bryan Wu >> Cc: Richard Purdie >> --- >> Documentation/leds/leds-class-flash.txt | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/leds/leds-class-flash.txt b/Documentation/leds/leds-class-flash.txt >> index 19bb673..8623413 100644 >> --- a/Documentation/leds/leds-class-flash.txt >> +++ b/Documentation/leds/leds-class-flash.txt >> @@ -20,3 +20,16 @@ Following sysfs attributes are exposed for controlling flash LED devices: >> - max_flash_timeout >> - flash_strobe >> - flash_fault >> + >> +A LED subsystem driver can be controlled also from the level of VideoForLinux2 >> +subsystem. In order to enable this CONFIG_V4L2_FLASH_LED_CLASS symbol has to >> +be defined in the kernel config. The driver must call the v4l2_flash_init >> +function to get registered in the V4L2 subsystem. On remove the >> +v4l2_flash_release function has to be called (see ). >> + >> +After proper initialization a V4L2 Flash sub-device is created. The sub-device >> +exposes a number of V4L2 controls, which allow for controlling a LED Flash class > > Over 80 characters per line. This line has exactly 80 characters, probably you checked the length in the patch, which includes leading '+' character. > > With this fixed, > > Acked-by: Sakari Ailus Probably I inadvertently changed the Acked-by email. Bryan, please apply the patch with: Acked-by: Sakari Ailus > >> +device with use of its internal kernel API. >> +Opening the V4L2 Flash sub-device makes the LED subsystem sysfs interface >> +unavailable. The interface is re-enabled after the V4L2 Flash sub-device >> +is closed. > -- Best Regards, Jacek Anaszewski