From: Scott Branden <sbranden@broadcom.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Lee Jones" <lee@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Ralf Baechle" <ralf@linux-mips.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: brcm: rationalize Broadcom documentation naming
Date: Wed, 18 Mar 2015 15:08:01 -0700 [thread overview]
Message-ID: <5509F741.5010206@broadcom.com> (raw)
In-Reply-To: <5509F61E.5000702@wwwdotorg.org>
On 15-03-18 03:03 PM, Stephen Warren wrote:
> On 03/18/2015 03:53 PM, Scott Branden wrote:
>> Hi Stephen,
>>
>> On 15-03-18 12:42 PM, Stephen Warren wrote:
>>> On 03/18/2015 01:24 PM, Scott Branden wrote:
>>>> This patchset attempts to standarize the naming of dt-bindings
>>>> documents based on the Broadcom vendor prefix of brcm.
>>>>
>>>> Although there are no guidelines currently present for how to name
>>>> the dt-bindings document the "vendor,binding.txt" style is in use by
>>>> some of the other vendors.
>>>
>>> Conceptually I'm fine with this.
>>> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
>>>
>>> The only comment I have is that some bindings refer to other bindings,
>>> e.g. an I2C controller binding might refer to the core I2C binding to
>>> define core I2C properties. Since this patch moves a couple files
>>> between directories, did you double-check that none of the pathnames in
>>> those references need fixing up?
>>
>> Yes, I read all the brcm documents and did not find references to the
>> moved files.
>
> Oh, I meant references *from* the moved files to other files.
Yes, some of the moved/renamed files reference other files. But those
are to references to common dt-binding documentation files and of the
form Documentation/devicetree/bindings/xxx/yyy.txt
>
> BTW, I just noticed that both your patches don't have signed-off-by lines.
Whoops - thanks - will have to correct. Plus, add your Acked-by.
prev parent reply other threads:[~2015-03-18 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:24 [PATCH] dt-bindings: brcm: rationalize Broadcom documentation naming Scott Branden
[not found] ` <1426706645-19313-1-git-send-email-sbranden-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-18 19:42 ` Stephen Warren
[not found] ` <5509D528.1080208-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2015-03-18 21:53 ` Scott Branden
2015-03-18 22:03 ` Stephen Warren
2015-03-18 22:08 ` Scott Branden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509F741.5010206@broadcom.com \
--to=sbranden@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=hauke@hauke-m.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).