From: Sudeep Holla <sudeep.holla@arm.com>
To: Mark Rutland <mark.rutland@arm.com>,
Suzuki Poulose <Suzuki.Poulose@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Nicolas Pitre <nico@linaro.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
Abhilash Kesavan <a.kesavan@samsung.com>,
Arnd Bergmann <arnd@arndb.de>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
Olof Johansson <olof@lixom.net>, Pawel Moll <Pawel.Moll@arm.com>,
Punit Agrawal <Punit.Agrawal@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver
Date: Thu, 19 Mar 2015 17:38:41 +0000 [thread overview]
Message-ID: <550B09A1.4020801@arm.com> (raw)
In-Reply-To: <20150319173252.GC10153@leverpostej>
On 19/03/15 17:32, Mark Rutland wrote:
> One more thing:
>
>> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
>> pdev->dev.of_node);
>> if (!match)
>> return NULL;
>> + if (match->data)
>> + return match->data;
>>
>> + dev_warn(&pdev->dev, "DEPRECATED compatible property,"
>> + "requires secure access to CCI registers");
>> return probe_cci_model(pdev);
>> }
>
> Before the probe, could we please have:
>
> if (!IS_ENABLED(CONFIG_ARM))
> return -EINVAL;
>
> On arm64 we require a model-specific string, and we shouldn't go
> touching secure-only registers.
>
IIUC platform_has_secure_cci_access always return false for ARM64
preventing any secure access. No ?
Regards,
Sudeep
next prev parent reply other threads:[~2015-03-19 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 15:18 [PATCHv3 0/5] arm-cci400: PMU monitoring support on ARM64 Suzuki K. Poulose
2015-03-10 15:18 ` [PATCH 1/5] arm-cci: Rearrange code for splitting PMU vs driver code Suzuki K. Poulose
2015-03-10 15:18 ` [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver Suzuki K. Poulose
2015-03-17 9:51 ` [UPDATED] " Suzuki K. Poulose
2015-03-19 17:25 ` Mark Rutland
[not found] ` <1426585901-19137-1-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-19 17:32 ` Mark Rutland
2015-03-19 17:38 ` Sudeep Holla [this message]
2015-03-19 17:52 ` Suzuki K. Poulose
[not found] ` <550B0CF6.8070205-5wv7dgnIgG8@public.gmane.org>
2015-03-19 17:54 ` Mark Rutland
2015-03-10 15:18 ` [PATCH 4/5] arm-cci: Split the code for PMU vs driver support Suzuki K. Poulose
[not found] ` <1426000735-14375-5-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-10 16:24 ` Sudeep Holla
2015-03-10 15:18 ` [PATCH 5/5] arm-cci: Fix CCI PMU event validation Suzuki K. Poulose
[not found] ` <1426000735-14375-6-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-17 18:52 ` Will Deacon
2015-03-10 16:21 ` [PATCHv3 0/5] arm-cci400: PMU monitoring support on ARM64 Sudeep Holla
2015-03-10 16:24 ` Suzuki K. Poulose
[not found] ` <1426000735-14375-1-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-10 15:18 ` [PATCH 2/5] arm-cci: Abstract the CCI400 PMU speicific definitions Suzuki K. Poulose
[not found] ` <1426000735-14375-3-git-send-email-suzuki.poulose-5wv7dgnIgG8@public.gmane.org>
2015-03-17 18:49 ` Will Deacon
2015-03-10 16:09 ` [PATCHv3 0/5] arm-cci400: PMU monitoring support on ARM64 Nicolas Pitre
2015-03-10 16:11 ` Suzuki K. Poulose
2015-03-11 11:40 ` Punit Agrawal
2015-03-17 18:54 ` Will Deacon
2015-03-18 10:09 ` Suzuki K. Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B09A1.4020801@arm.com \
--to=sudeep.holla@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Liviu.Dudau@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=Punit.Agrawal@arm.com \
--cc=Suzuki.Poulose@arm.com \
--cc=Will.Deacon@arm.com \
--cc=a.kesavan@samsung.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nico@linaro.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).