From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions
 for PMU driver
Date: Thu, 19 Mar 2015 17:38:41 +0000
Message-ID: <550B09A1.4020801@arm.com>
References: <1426000735-14375-4-git-send-email-suzuki.poulose@arm.com> <1426585901-19137-1-git-send-email-suzuki.poulose@arm.com> <20150319173252.GC10153@leverpostej>
Mime-Version: 1.0
Content-Type: text/plain; charset=WINDOWS-1252; format=flowed
Content-Transfer-Encoding: 8BIT
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20150319173252.GC10153@leverpostej>
Sender: linux-kernel-owner@vger.kernel.org
To: Mark Rutland <mark.rutland@arm.com>, Suzuki Poulose <Suzuki.Poulose@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Nicolas Pitre <nico@linaro.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Kukjin Kim <kgene@kernel.org>, Abhilash Kesavan <a.kesavan@samsung.com>, Arnd Bergmann <arnd@arndb.de>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Liviu Dudau <Liviu.Dudau@arm.com>, Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>, Olof Johansson <olof@lixom.net>, Pawel Moll <Pawel.Moll@arm.com>, Punit Agrawal <Punit.Agrawal@arm.com>, Will Deacon <Will.Deacon@arm.com>, Catalin Marinas <Catalin.Marinas@arm.com>
List-Id: devicetree@vger.kernel.org



On 19/03/15 17:32, Mark Rutland wrote:
> One more thing:
>
>> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
>>   							pdev->dev.of_node);
>>   	if (!match)
>>   		return NULL;
>> +	if (match->data)
>> +		return match->data;
>>
>> +	dev_warn(&pdev->dev, "DEPRECATED compatible property,"
>> +			 "requires secure access to CCI registers");
>>   	return probe_cci_model(pdev);
>>   }
>
> Before the probe, could we please have:
>
> 	if (!IS_ENABLED(CONFIG_ARM))
> 		return -EINVAL;
>
> On arm64 we require a model-specific string, and we shouldn't go
> touching secure-only registers.
>

IIUC platform_has_secure_cci_access always return false for ARM64
preventing any secure access. No ?

Regards,
Sudeep