devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: Walter Lozano <walter@vanguardiasur.com.ar>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	linux@arm.linux.org.uk,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH v2] ARM: socfpga: dts: Add adxl34x
Date: Sun, 22 Mar 2015 22:03:51 -0500	[thread overview]
Message-ID: <550F8297.80809@opensource.altera.com> (raw)
In-Reply-To: <CABxpGwAFdLET+fg3WvMWqXdzsPQHv3hKx9cFwk9RQE9w6+rEbg@mail.gmail.com>

Hi Walter,

On 3/19/15 4:27 PM, Walter Lozano wrote:
> Hi Dinh,
> 
> On Mon, Mar 16, 2015 at 10:10 AM, Walter Lozano
> <walter@vanguardiasur.com.ar> wrote:
>> On Mon, Jan 5, 2015 at 6:21 AM, Steffen Trumtrar
>> <s.trumtrar@pengutronix.de> wrote:
>>> Hi!
>>>
>>> On Wed, Dec 24, 2014 at 08:11:52PM -0300, Walter Lozano wrote:
>>>> This patch adds the DTS bindings for the adxl34x digital
>>>> accelerometer.
>>>>
>>>> Signed-off-by: Walter Lozano <walter@vanguardiasur.com.ar>
>>>> ---
>>>>  arch/arm/boot/dts/socfpga_cyclone5_sockit.dts |   16 ++++++++++++++++
>>>>  1 file changed, 16 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> index 16ea6f5..d343e03 100644
>>>> --- a/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sockit.dts
>>>> @@ -60,6 +60,22 @@
>>>>       rxc-skew-ps = <2000>;
>>>>  };
>>>>
>>>> +&gpio2 {
>>>> +     status = "okay";
>>>> +};
>>>> +
>>>> +&i2c1 {
>>>> +     status = "okay";
>>>> +
>>>> +     accel1: accelerometer@53 {
>>>> +             compatible = "adxl34x";

Shouldn't this be "adi,adxl34x"? At least that's what the documentation
says.

>>>> +             reg = <0x53>;
>>>> +
>>>> +             interrupt-parent = <&portc>;
>>>> +             interrupts = <3 2>;
>>>> +     };
>>>> +};
>>>> +
>>>>  &mmc0 {
>>>>       vmmc-supply = <&regulator_3_3v>;
>>>>       vqmmc-supply = <&regulator_3_3v>;
>>>
>>> I just gave it a short spin. I get some interrupts and the position property
>>> changes, so it seems to work:
>>>
>>>         Acked-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
>>>
>>
>> Ping?
>> How should this continue?
> 
> Any news about this patch? It has been acked by Pavel Machek and
> Steffen Trumtrar a while ago.
>

Sorry, since I wasn't CC on the original patch and somehow my filter
didn't catch it, I didn't see this patch until now.

Dinh

  reply	other threads:[~2015-03-23  3:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-24 23:11 [PATCH v2] ARM: socfpga: dts: Add adxl34x Walter Lozano
2015-01-02  5:11 ` Pavel Machek
     [not found] ` <1419462712-14151-1-git-send-email-walter-30ULvvUtt6G51wMPkGsGjgyUoB5FGQPZ@public.gmane.org>
2015-01-05  9:21   ` Steffen Trumtrar
2015-03-16 13:10     ` Walter Lozano
     [not found]       ` <CABxpGwCbFF+pJ0H_sMjqk6c9awdRuxi6j0CL_d3mH5z4Qht+ng-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-03-19 21:27         ` Walter Lozano
2015-03-23  3:03           ` Dinh Nguyen [this message]
     [not found]             ` <550F8297.80809-yzvPICuk2ABMcg4IHK0kFoH6Mc4MB0Vx@public.gmane.org>
2015-03-24  2:29               ` Walter Lozano
     [not found]                 ` <CABxpGwA3cs11Wtvs_8iGka9anb2+vHhfph19VKbTwBJOeh9bbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-23 20:20                   ` Walter Lozano
2015-06-25  7:28                     ` Geert Uytterhoeven
     [not found]                       ` <CAMuHMdW5EG+LnWE7sFYVJKHjN=k7mUUp7U5-r3hMjQvsKgf3ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-25 17:01                         ` Walter Lozano
2015-06-25 17:05                           ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550F8297.80809@opensource.altera.com \
    --to=dinguyen@opensource.altera.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    --cc=walter@vanguardiasur.com.ar \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).