From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CCCC25B0E for ; Fri, 19 Aug 2022 06:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344539AbiHSGw4 (ORCPT ); Fri, 19 Aug 2022 02:52:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244716AbiHSGwz (ORCPT ); Fri, 19 Aug 2022 02:52:55 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D89CFD7D32 for ; Thu, 18 Aug 2022 23:52:53 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id i19so4945731lfr.10 for ; Thu, 18 Aug 2022 23:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Y5uL27unbAtFFDXV9O3CJy9VefjqDxgpHdg47Nmbfy4=; b=JgBlkJi/LL6K3LjSxJ5NaoyL5BIk+UWEvHJlvFGRUd5P2Tqm3jfQgYVHdJOg0xryIB GJm4B+LbzlK2LJwNZXcVQbN06lXwPH55d8MdV4WmkmCxk7rGBdS13j4k9kTuOuwcRJzw /3k/WsNbtvkDOO6weB25lLpfxynHio9ObvCfNkmbAXBgI7Mf51St0nnAAnwxkav6GUR5 JT6WzB2yMleHZvQyVdhl2jTjv6w1epULwVXWZbtd6QM9mLaIFRaF3Ky3Ycpkxtlb9oDc DS3Gob/+/kkYZE/fq2qMm76ysTW4vHhPUol70fSU5yRvJpUgYubmQ7h1SHeFM06cIZJW bGmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Y5uL27unbAtFFDXV9O3CJy9VefjqDxgpHdg47Nmbfy4=; b=LuoindMvMmGaG5Pftfw8YDAl1HHbgChmSkvzYKX6JqDC6qqWZr92YppHY+GcCfz1pZ GT8zq7XB2BFIFNRhEhfmYpyMtV/SrKJMwco65FYcMl3yXXhy43FuMRDC7fmmNNudPdz5 RA8SO7x/AdeWRHlKt4w9rNqNM8WrYoK18ec3goQ/v6d/Be585kznaslvHDd5j52muNba 05+Z29A9Us6UaUoTk4rOMbkWxMjiIdGnvJYCOv7zhMY6jaxr8UtkXNB3atfq+MMBUHZs rAW60Z11JNdDyN0FsTJ6SE2L8d9ox8QcwUryRaAWFqb3iEzaUGeS+2zpIpU7RqaEfMph N/7Q== X-Gm-Message-State: ACgBeo3hQKwd41X+UavWQmrwF2nUZpNKQYb2rpvgIfyXaheZIumj2GXB uaf+zPag5GPi+9+uerJDW1qU4w== X-Google-Smtp-Source: AA6agR4mH2mFYS7o54N5XSepotC6RrBaYjnakDvALchOSSqNl8yUhTN1K7TsMONWgIW9k7PxrTx/bQ== X-Received: by 2002:a05:6512:4009:b0:491:bdd9:eab1 with SMTP id br9-20020a056512400900b00491bdd9eab1mr2177454lfb.372.1660891972252; Thu, 18 Aug 2022 23:52:52 -0700 (PDT) Received: from ?IPV6:2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5? (d1xw6v77xrs23np8r6z-4.rev.dnainternet.fi. [2001:14bb:ac:e5a8:ef73:73ed:75b3:8ed5]) by smtp.gmail.com with ESMTPSA id a19-20020ac25e73000000b0048aa64cfef6sm172941lfr.152.2022.08.18.23.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Aug 2022 23:52:51 -0700 (PDT) Message-ID: <550e652e-4541-c1e6-33a7-d5555f0cb266@linaro.org> Date: Fri, 19 Aug 2022 09:52:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 1/2] dt-bindings: lan966x-otpc: document Lan966X OTPC Content-Language: en-US To: Horatiu Vultur , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: srinivas.kandagatla@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20220818164405.1953698-1-horatiu.vultur@microchip.com> <20220818164405.1953698-2-horatiu.vultur@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20220818164405.1953698-2-horatiu.vultur@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/08/2022 19:44, Horatiu Vultur wrote: > Document Lan966x OTP controller. > > Signed-off-by: Horatiu Vultur > --- > .../nvmem/microchip,lan966x-otpc.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > > diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > new file mode 100644 > index 000000000000..b19465971930 > --- /dev/null > +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan966x-otpc.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/nvmem/microchip,lan966x-otpc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN966X OTP Controller (OTPC) > + > +maintainers: > + - Horatiu Vultur > + > +description: | > + OTP controller drives a NVMEM memory where system specific data > + (e.g. hardware configuration settings, chip identifiers) or > + user specific data could be stored. > + > +allOf: > + - $ref: "nvmem.yaml#" No need for quotes. > + > +properties: > + compatible: > + items: > + - const: microchip,lan966x-otpc No wildcards in compatible (which will also affect the file name as it should match the compatible). > + - const: syscon Is OTP controller also system controller register region? This is a bit odd and looks like hack not to use nvmem subsystem. > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + otpc: otp@e0021000 { > + compatible = "microchip,lan966x-otpc", "syscon"; > + reg = <0xe0021000 0x300>; > + }; > + > +... Best regards, Krzysztof