From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v1 01/11] leds: Add support for max77693 mfd flash cell Date: Mon, 23 Mar 2015 14:22:39 +0100 Message-ID: <5510139F.4030807@samsung.com> References: <1426863811-12516-1-git-send-email-j.anaszewski@samsung.com> <1426863811-12516-2-git-send-email-j.anaszewski@samsung.com> <20150321224437.GD16613@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150321224437.GD16613@valkosipuli.retiisi.org.uk> Sender: linux-media-owner@vger.kernel.org To: Sakari Ailus Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kyungmin.park@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, s.nawrocki@samsung.com, Andrzej Hajda , Lee Jones , Chanwoo Choi List-Id: devicetree@vger.kernel.org Hi Sakari, Thanks for the review. On 03/21/2015 11:44 PM, Sakari Ailus wrote: > Hi Jacek, > > On Fri, Mar 20, 2015 at 04:03:21PM +0100, Jacek Anaszewski wrote: >> This patch adds led-flash support to Maxim max77693 chipset. >> A device can be exposed to user space through LED subsystem >> sysfs interface. Device supports up to two leds which can >> work in flash and torch mode. The leds can be triggered >> externally or by software. >> >> Signed-off-by: Jacek Anaszewski >> Signed-off-by: Andrzej Hajda >> Acked-by: Kyungmin Park >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: Lee Jones >> Cc: Chanwoo Choi > > Thanks for the update once again! > > Acked-by: Sakari Ailus > There will be one more version of this patch due to some changes around flash settings and v4l2-flash config initialization, requested in the review of v4l2-flash helpers related patches. -- Best Regards, Jacek Anaszewski